Fix two LSH issues - #901
Merged
Merged
Conversation
DHowett
reviewed
Jul 28, 2026
| 't' => Ok(Atom::Char('\t')), | ||
| 'x' => { | ||
| if let Some(byte) = | ||
| self.rest().get(..2).and_then(|hex| u8::from_str_radix(hex, 16).ok()) |
Member
There was a problem hiding this comment.
i do not comprehend how consuming only 2 characters after x will allow for something that is > 0xff in Atom::Char above
Member
Author
There was a problem hiding this comment.
Atom::Char can contain any codepoints! For instance, a regex like: [😄-🙂]
Member
There was a problem hiding this comment.
yes but..
Adds support for specifying non-ASCII regex atoms
via \xNN escape sequences
i mean, technically this is true because 0x80-0xff is not ASCII
but it is surely not true in the spirit of it ;P
Member
Author
There was a problem hiding this comment.
Well, sorta. I need this to implement partial UTF8 support in one particular place by writing [^'][\x80-\xBF]*
DHowett
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
with an optional alternation like
[ab]?cvia
\xNNescape sequences