Fix JSONL loader handling of blank/invalid lines#2434
Open
natoverse wants to merge 3 commits into
Open
Conversation
Collaborator
Author
|
This replaces #2423 to include more handling of edge cases |
gaudyb
reviewed
Jul 11, 2026
| @@ -40,3 +40,20 @@ async def test_jsonl_loader_one_file_with_title(): | |||
| documents = await reader.read_files() | |||
| assert len(documents) == 3 | |||
Contributor
There was a problem hiding this comment.
for this test, is it better to have this fixed value "3" as a default value on top of the test? to understand better why and also to change it in case you want to test something else.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2424