Skip to content

fix(tracing): send addStackToTracingNoReply on the LocalUtils connection #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
monkey (Develop-KIM) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(tracing): send addStackToTracingNoReply on the LocalUtils connection #1967

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion playwright/src/main/java/com/microsoft/playwright/impl/Connection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,8 @@ private WaitableResult<JsonElement> internalSendMessage(String guid, String meth
callData.add("stack", stack);
JsonObject stackParams = new JsonObject();
stackParams.add("callData", callData);
internalSendMessage(localUtils.guid,"addStackToTracingNoReply", stackParams, null, false, true);
// LocalUtils belongs to the driver connection, which is not this one when the browser came from connect().
localUtils.connection.internalSendMessage(localUtils.guid,"addStackToTracingNoReply", stackParams, null, false, true);
}
return result;
}
Expand Down