Skip to content

Enable noUncheckedSideEffectImports by default - #2864

Merged
Jake Bailey (jakebailey) merged 6 commits into
microsoft:mainfrom
Andarist:fix/make-sure-noUncheckedSideEffectImports
Feb 21, 2026
Merged

Enable noUncheckedSideEffectImports by default#2864
Jake Bailey (jakebailey) merged 6 commits into
microsoft:mainfrom
Andarist:fix/make-sure-noUncheckedSideEffectImports

Conversation

@Andarist

Copy link
Copy Markdown
Contributor

Comment thread internal/checker/checker.go
Comment thread internal/tsoptions/declscompiler.go
@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Feb 21, 2026
@jakebailey
Jake Bailey (jakebailey) removed this pull request from the merge queue due to a manual request Feb 21, 2026
@jakebailey
Jake Bailey (jakebailey) added this pull request to the merge queue Feb 21, 2026
Merged via the queue into microsoft:main with commit 5c412f3 Feb 21, 2026
21 checks passed
@Meligy

Copy link
Copy Markdown

This breaks .scss imports even when you have fake modules for them.

@jakebailey

Copy link
Copy Markdown
Member

Please file an issue with a repro. That should not be the case https://devblogs.microsoft.com/typescript/announcing-typescript-5-6/#the---nouncheckedsideeffectimports-option

@pedro757

Copy link
Copy Markdown

I can confirm this breaks css imports

@Andarist

Copy link
Copy Markdown
Contributor Author

Please open a new issue with the repro steps included. Ideally, one that would showcase the difference between typescript@next and tsgo

roboin (Robot-Inventor) added a commit to Robot-Inventor/tsconfig-base that referenced this pull request Feb 24, 2026
the latest TypeScript changes

Previously, `noUncheckedSideEffectImports` was disabled by default in
TypeScript, but it has recently been enabled by default. Since this
option can break existing projects that use CSS Modules, this commit
explicitly disables it to maintain the previous behavior.

Ref:

- microsoft/TypeScript#62443
- microsoft/typescript-go#2864
roboin (Robot-Inventor) added a commit to Robot-Inventor/tsconfig-base that referenced this pull request Feb 24, 2026
#77)

the latest TypeScript changes

Previously, `noUncheckedSideEffectImports` was disabled by default in TypeScript, but it has recently been enabled by default. Since this option can break existing projects that use CSS Modules, this commit explicitly disables it to maintain the previous behavior.

Ref:

- microsoft/TypeScript#62443
- microsoft/typescript-go#2864
Copilot AI pushed a commit that referenced this pull request Feb 25, 2026
@pedro757

Pedro Sanchez (pedro757) commented Feb 26, 2026

Copy link
Copy Markdown

Mateusz Burzyński (@Andarist) Jake Bailey (@jakebailey) I filed the issue with a repro sandbox #2912

Jake Bailey (jakebailey) pushed a commit to jakebailey/TypeScript that referenced this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants