test: enforce headless package manager conformance - #1717
Open
Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Open
test: enforce headless package manager conformance#1717Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Eduardo Villalpando Mello (edvilme) wants to merge 2 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 3fd1a810-6840-4ac9-ac33-c8a9fda4bfc4
Copilot started reviewing on behalf of
Eduardo Villalpando Mello (edvilme)
August 17, 2026 23:50
View session
Contributor
There was a problem hiding this comment.
Pull request overview
Adds unit-level “headless conformance” coverage to ensure package manager operations (Pip/Conda/Poetry) do not prompt for interactive input or display error UI when runHeadless: true, while still rejecting on failures. Also aligns Pip’s UI entry points with the existing VS Code wrapper APIs so they can be controlled/stubbed consistently in tests.
Changes:
- Added a shared unit test suite that exercises headless package-management behavior across Pip, Conda, and Poetry.
- Updated
PipPackageManagerto usewithProgress/showErrorMessagefromcommon/window.apisinstead ofvscode.windowdirectly.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/test/managers/common/packageManagerHeadlessConformance.unit.test.ts | New conformance unit tests asserting headless runs do not prompt and do not show error UI, while failures still reject. |
| src/managers/builtin/pipPackageManager.ts | Switched from vscode.window to window API wrappers for progress + error UI to support headless/test stubbing. |
Suppressed comments (1)
src/managers/builtin/pipPackageManager.ts:82
- New/updated user-facing strings in this hunk (progress titles like "Installing packages" and the error UI text/button) are not localized. The repo consistently localizes UI strings via
l10n.t(...)or centralized string modules (e.g.,CondaStringsfromsrc/common/localize.ts). Please localize these strings so they’re translatable.
await withProgress(
{
location: ProgressLocation.Notification,
title: 'Installing packages',
cancellable: true,
},
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1704. Adds shared conformance coverage ensuring Pip, Conda, and Poetry do not prompt or show error UI during headless package operations, while failures still reject.