[WIP] Unify editor suggest widget and suggest details styling#325366
Draft
hawkticehurst wants to merge 1 commit into
Draft
[WIP] Unify editor suggest widget and suggest details styling#325366hawkticehurst wants to merge 1 commit into
hawkticehurst wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hawkticehurst
changed the title
Contributor
Screenshot ChangesBase: Changed (4)
|
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MethodCompletions/Light
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MixedKinds/Dark
| Before | After |
|---|---|
 |
 |
editor/suggestWidget/MixedKinds/Light
| Before | After |
|---|---|
 |
 |
1 insignificant change(s) omitted (≤20 px, Δ≤2). See CI logs for details.
Added (2)
editor/suggestWidget/MethodCompletionsWithDetails/Dark
editor/suggestWidget/MethodCompletionsWithDetails/Light
Contributor
There was a problem hiding this comment.
Pull request overview
Unifies suggestion widget and details styling across placements and themes.
Changes:
- Applies themed shadows and placement-aware corner radii.
- Tracks details placement through shared CSS classes.
- Adds screenshot fixture coverage for visible details.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
suggestWidgetDetails.ts |
Tracks details placement and alignment. |
suggestWidget.ts |
Connects the suggest widget DOM to the details overlay. |
suggest.css |
Adds themed shadows and docked corner styling. |
roundedCorners.css |
Adds corresponding Modern UI overrides. |
suggestWidget.fixture.ts |
Adds a visible-details screenshot fixture. |
| maxSize = placement.maxSizeTop; | ||
| } | ||
| } | ||
| this._setPlacement(placement.className, alignAtTop ? 'details-align-top' : 'details-align-bottom'); |
| }), | ||
| }), | ||
|
|
||
| MethodCompletionsWithDetails: defineComponentFixture({ |
hawkticehurst
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm run typecheck-clientgulp compile-clientnpm run valid-layers-checkManual verification
Open JavaScript suggestions for
window.with details visible. Check standalone and east/west/north/south placements in Light+, Dark+, HC Light/Black, and Modern UI on/off, including a customizedwidget.shadow.Fixes #324994