feat(container): support env var expansion in consuming commands - #2023
Open
gandie wants to merge 7 commits into
Open
feat(container): support env var expansion in consuming commands#2023gandie wants to merge 7 commits into
gandie wants to merge 7 commits into
Conversation
martin-helmich
changed the title
martin-helmich
approved these changes
Jul 24, 2026
Comment on lines
+53
to
+59
| export function makeContainerDescriptionFlagOptions(summary: string) { | ||
| return Flags.custom<string>({ | ||
| summary, | ||
| description: "This helps identify the container's purpose or contents.", | ||
| required: false, | ||
| })(); | ||
| } |
Member
There was a problem hiding this comment.
Flags.custom already exports a constructor function; the idiomatic usage would be this:
// Export
export const containerDescriptionFlag = Flags.custom<string>({
summary,
description: "This helps identify the container's purpose or contents.",
required: false,
});
// Usage
const flags = {
description = containerDescriptionFlag({
summary: "boo"
})
}
martin-helmich
requested changes
Jul 29, 2026
Comment on lines
62
to
64
| summary: "override the default entrypoint of the container image", | ||
| description: | ||
| "The entrypoint is the command that will be executed when the container starts. If omitted, the entrypoint defined in the image will be used.", |
Member
There was a problem hiding this comment.
I think we could also move summary+description to the custom flag definition
Comment on lines
73
to
74
| summary: "publish a container's port(s)", | ||
| description: |
Member
There was a problem hiding this comment.
I think we could also move summary+description to the custom flag definition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve #1572
Tested in fish shell:
Container spawns with password and starts without errors.