mcp: add ServerSession.NotifyElicitationComplete - #1194
Merged
guglielmo-san merged 2 commits intoAug 24, 2026
Conversation
URL-mode elicitation is only half-usable from outside the module. A server can reject a request with URLElicitationRequiredError, and the client then registers a waiter and blocks the originating request until notifications/elicitation/complete arrives, but nothing exported can send that notification. The two in-tree tests that complete the handshake reach for the unexported handleNotify, which an external server cannot do, so in practice the client waits until its context is cancelled. Add ServerSession.NotifyElicitationComplete, and switch both tests to it so the exported path is the one under test. Nil params and an empty ElicitationID are rejected rather than sent, since the client cannot match either to a pending elicitation.
…plementation details
guglielmo-san
enabled auto-merge (squash)
August 24, 2026 08:12
nahapetyan-serob
approved these changes
Aug 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds:
As according to spec