docs: clarify when Client(raise_exceptions=True) actually raises - #3289
docs: clarify when Client(raise_exceptions=True) actually raises#3289HaoChiBao wants to merge 2 commits into
Conversation
Document that the flag only unsanitises unexpected in-memory handler crashes (still MCPError, with message/__cause__), leaves tool is_error results alone, and is ignored for URL/transport clients. Fixes modelcontextprotocol#3287.
Keep the full semantics on the Testing page and the low-level-server cross-link; the troubleshooting tip restated the same material.
|
This PR has been closed automatically. It's still a draft, but we close those early so you don't put in more time only to have it closed the moment you mark it ready. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #3287. If a maintainer assigns you to #3287, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
Client(raise_exceptions=True): in-memory only; still raisesMCPErroron unexpected handler crashes, but unsanitises the message and chains__cause__; does not turn toolis_error=Trueinto an exception; ignored for URL/transport clients; drop onmode="legacy".Client.raise_exceptionsTODO with a docstring that matches that behaviour.docs_src/testing/tutorial002.pyplus docs_src tests covering the True/False contrast.Fixes #3287.
AI disclosure
This contribution was prepared with AI assistance (Cursor). A human reviewed the traced behaviour and the docs/tests before opening the PR.
Test plan
uv run --frozen ruff format/ruff checkon touched Python files