[v1.x] fix: make MCP errors pickle-safe - #3410
Conversation
Co-authored-by: openhands <openhands@all-hands.dev> Signed-off-by: King Star <mcxin.y@gmail.com>
|
This PR has been closed automatically. This repo only keeps pull requests open when they come from a maintainer, or from a contributor a maintainer has assigned to the linked issue, and you aren't currently assigned to #2431. If a maintainer assigns you to #2431, this PR reopens on its own and there's nothing more you need to do here. Assignment is a maintainer call based on capacity; comments that only ask to be assigned don't factor in. What does help is engaging on the issue itself by confirming the repro, explaining why it matters for your use case, or describing the approach you'd take. You're welcome to keep pushing commits here (just avoid force-pushing, since GitHub can't reopen a rewritten branch), but that on its own won't get the PR reviewed or the issue assigned, and realistically most auto-closed PRs stay closed. There's no need to open a new PR either way. CONTRIBUTING.md has the full reasoning, but in short:
Maintainers: reopen, remove |
Summary
McpErrorusing its completeErrorDatapayload.UrlElicitationRequiredErrorthrough its existingfrom_errorparser.Fixes #2431
Verification
uv run --frozen pytest tests/shared/test_exceptions.py tests/shared/test_session.py tests/client/test_stdio.py -qNO_PROXY="*" no_proxy="*" ALL_PROXY="" all_proxy="" HTTP_PROXY="" http_proxy="" HTTPS_PROXY="" https_proxy="" ./scripts/test(1184 passed,95 skipped,1 xfailed,100.00%coverage)uv run --frozen pyrightuv run --frozen ruff check src/mcp/shared/exceptions.py tests/shared/test_exceptions.pyAI assistance was used during investigation and drafting; I reviewed the implementation, regression coverage, and verification results personally.