fix(realtime): accept bounded partial VAD overrun - #3591
Open
LauraGPT wants to merge 1 commit into
Open
Conversation
Signed-off-by: LauraGPT <18321252+LauraGPT@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
114430/126976/126740mstrace and a farther-overrun rejection testRoot cause
The follow-up on #3302 used exact merge
2b6294d69e6588a63c0ce06300f1b55ded71ae58and still locked a complete partial down to哎. The last partial covered114430-126976ms, while FSMN-VAD emitted114430-126740ms.The long-segment reconciliation gate only accepted
tail_gap_ms >= 0. Normal decode/VAD scheduling therefore rejected this candidate solely because it ended 236ms after the VAD boundary, before the single-character regression check could run.The new lower bound allows at most one decode chunk of overrun. Existing exact start alignment, repeated observations, long-segment duration, text alignment, and hallucination gates remain unchanged. A partial more than two chunks past this concrete boundary remains rejected by regression coverage.
Verification
Exact signed+DCO head:
980765099dea8d9f34ea2f10889b3ab1c3876173哎git diff --check: passedRelated to #3302. Merging this PR is not reporter confirmation; keep the issue open until the original file-upload and microphone paths are retested.
Signed-off-by: LauraGPT 18321252+LauraGPT@users.noreply.github.com