fix(core): normalize model base URL to origin#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bl config agentprovider Base URL behavior unchangedWhy
Users may copy a model-specific endpoint such as
https://example.com/api/v1/agentstudioand provide it asbase_url. The previous suffix-based normalization preserved unknown paths, so the CLI could append its own endpoint path to an already specific API path.The model-domain
base_urlcontract is now unambiguous: it is the service origin, and CLI commands append their own API paths.Impact
https://example.com/api/v1/agentstudionow normalizes tohttps://example.com. Path-mounted gateway prefixes are no longer retained. URLs with explicit ports, such ashttp://localhost:8080/path, normalize tohttp://localhost:8080.Validation
vp test run packages/core/tests/model-base-url.test.ts packages/core/tests/config-store.test.ts packages/core/tests/config-priority.test.ts packages/core/tests/index.test.ts packages/commands/tests/config-ui.test.ts packages/commands/tests/e2e/config.e2e.test.ts— 87 tests passedvp check— formatting, lint, and type checks passed