Skip to content

fix(keymap): restore handling of shift/capslock (@fehmer) - #8285

Open
fehmer wants to merge 4 commits into
masterfrom
feature/capslock-numrow
Open

fix(keymap): restore handling of shift/capslock (@fehmer)#8285
fehmer wants to merge 4 commits into
masterfrom
feature/capslock-numrow

Conversation

@fehmer

@fehmer fehmer commented Jul 26, 2026

Copy link
Copy Markdown
Member

fixes #8283
fixes #8282

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label Jul 26, 2026
@fehmer

fehmer commented Jul 26, 2026

Copy link
Copy Markdown
Member Author

@Leonabcd123 can you give it a test please?

@RedPandaGuy1234

Copy link
Copy Markdown

@Leonabcd123 can you give it a test please?

Hi, I'm not Leonabcd123, but the reason why there is a failing check is because in the github workflow document, there is an error, which I fixed in #8284. Once it gets approved, the check will be successful.

@fehmer
fehmer marked this pull request as draft July 27, 2026 14:50
@fehmer fehmer added the force-ci Force CI to run on draft PRs label Jul 27, 2026

@Leonabcd123 Leonabcd123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes #8282, but still doesn't fully fix #8283, because we still show the shifted layer for symbols outside the first row (say the comma key) when Caps Lock is enabled.

Comment thread frontend/src/ts/components/pages/test/Keymap.tsx
@fehmer

fehmer commented Jul 27, 2026

Copy link
Copy Markdown
Member Author

@Leonabcd123 what about now?

@Leonabcd123 Leonabcd123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both bugs seem to be gone, nice job.

@fehmer
fehmer marked this pull request as ready for review July 27, 2026 19:54
@github-actions github-actions Bot added the waiting for review Pull requests that require a review before continuing label Jul 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

force-ci Force CI to run on draft PRs frontend User interface or web stuff waiting for review Pull requests that require a review before continuing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Keymap shows wrong layer for symbols when Caps Lock is enabled Keymap still shows uppercased letters when both Caps Lock and shift are enabled

4 participants