fix(docker): list the apps after apps-writable is a known apps path - #1063
Conversation
2bffbd8 to
1534520
Compare
| ### Fixed | ||
| * fix(docker): create `apps-writable` as root so bind mounted apps can be used | ||
| * fix(docker): list the apps only after `apps-writable` is a known apps path | ||
|
|
There was a problem hiding this comment.
this is generated on release
susnux
left a comment
There was a problem hiding this comment.
one comment - otherwise looks good
`app:list` was queried before `apps.config.php` registers `apps-writable` as an apps path, so a bind mounted app is missing from the list. It is then not found in `shipped.json` either and ends up in the app store branch, where `app:install --force` exits non-zero with "<app> already installed". Signed-off-by: Florian Ludwig <florian@krautnerds.de>
3c205ee to
137ccb7
Compare
apps-writable is a known apps path
|
@susnux heads up, I rebased this on the current #1061 landed in the meantime and already contains the What is left is only the app list ordering: The CHANGELOG change is gone as well, thanks for the pointer. |
Rebased on the current
mainand reduced to what is left. #1061 already fixed thechownpart independently, so only the app list ordering remains.Problem
configureNextcloud()fails as soon as an app is bind mounted intoapps-writable, whichstartNextcloud(branch, true)does by default:app:listis queried beforeapps.config.phpregistersapps-writableas an apps path, so the mounted app is missing from the list. It is then not found inshipped.jsoneither and ends up in the app store branch, whereapp:install --forceexits non-zero with "already installed".The repo's own test suite passes
mountApp: false, so this is not covered by CI.Fix
Build the app list only after
apps.config.phphas been written. Four lines moved, no behaviour change for the non mounted case.Testing
npm run lint,npm run build,npx tsc --noEmitcleannpm run test:node4/4 pass (unchanged behaviour,mountApp: false)nextcloud/attendance,stable34, macOS + Docker Desktop):configureNextcloudnow completes and reportsattendance 1.42.0 enabledinstead of aborting. The same run also confirmed that with the named volume from fix(podman): Ensure compatibility with Podman #1061 themkdirno longer needs to run as root, so that part of my original change is gone.