chore: continue ts migration

lib/Controller/PageController.php

@@ -112,6 +112,16 @@ public function views(string $hash): TemplateResponse {
 		return $this->index($hash);
 	}
 
+	/**
+	 * @return TemplateResponse
+	 */
+	#[NoAdminRequired()]
+	#[NoCSRFRequired()]
+	#[FrontpageRoute(verb: 'GET', url: '/{hash}/results/{view}', requirements: ['hash' => '[a-zA-Z0-9]{16,}'])]
+	public function resultsViews(string $hash): TemplateResponse {
+		return $this->index($hash);
+	}
+
 	/**
 	 * @return TemplateResponse
 	 */

package.json

@@ -23,7 +23,8 @@
     "lint:fix": "eslint --ext .js,.ts,.vue src --fix",
     "start:nextcloud": "node playwright/start-nextcloud-server.mjs",
     "stylelint": "stylelint \"src/**/*.scss\" \"src/**/*.vue\"",
-    "stylelint:fix": "stylelint \"src/**/*.scss\" \"src/**/*.vue\" --fix"
+    "stylelint:fix": "stylelint \"src/**/*.scss\" \"src/**/*.vue\" --fix",
+    "typecheck": "vue-tsc --noEmit -p tsconfig.json"
   },
   "browserslist": [
     "extends @nextcloud/browserslist-config"
@@ -58,12 +59,15 @@
     "@nextcloud/stylelint-config": "^3.2.2",
     "@nextcloud/vite-config": "^2.5.2",
     "@playwright/test": "^1.62.1",
+    "@types/markdown-it": "^14.1.2",
     "@types/node": "^26.1.2",
+    "@types/qrcode": "^1.5.6",
     "@vue/tsconfig": "^0.9.1",
     "eslint-config-prettier": "^10.1.8",
     "eslint-plugin-prettier": "^5.5.6",
     "prettier": "^3.9.6",
-    "vite": "^7.3.6"
+    "vite": "^7.3.6",
+    "vue-tsc": "^3.3.7"
   },
   "engines": {
     "node": "^24.0.0",

playwright/e2e/results-view.spec.ts

@@ -51,11 +51,9 @@ test.describe('Results view', () => {
 		await submitView.submit()
 		await expect(submitView.successMessage).toBeVisible()
 
-		// Navigate to Results view via URL — the SPA route transition
-		// from submit → results after submission causes a brief redirect loop,
-		// so we use direct navigation instead of clicking the TopBar.
+		// Navigate to Results view. The router will redirect to the summary tab.
 		await page.goto(page.url().replace(/\/submit.*$/, '/results'))
-		await page.waitForURL(/\/results(?:\?.*)?$/)
+		await page.waitForURL(/\/results\/summary$/)
 	})
 
 	test('Summary tab shows submitted data', async ({ resultsView }) => {
@@ -80,76 +78,38 @@ test.describe('Results view', () => {
 		// Should show the individual submission with the answers
 		await expect(resultsView.responsesTab).toBeChecked()
 		await expect(resultsView.responseCount).toBeVisible()
-		await expect(resultsView.page).toHaveURL(/\/results\?view=responses$/)
+		await expect(resultsView.page).toHaveURL(/\/results\/responses$/)
 	})
 
 	test('Tab switching between Summary and Responses updates the URL', async ({
 		resultsView,
 	}) => {
 		// Start on Summary
 		await expect(resultsView.summaryTab).toBeChecked()
-		await expect(resultsView.page).toHaveURL(/\/results\?view=summary$/)
+		await expect(resultsView.page).toHaveURL(/\/results\/summary$/)
 
 		// Switch to Responses
 		await resultsView.switchToResponses()
 		await expect(resultsView.responsesTab).toBeChecked()
 		await expect(resultsView.summaryTab).not.toBeChecked()
-		await expect(resultsView.page).toHaveURL(/\/results\?view=responses$/)
+		await expect(resultsView.page).toHaveURL(/\/results\/responses$/)
 
 		// Switch back to Summary
 		await resultsView.switchToSummary()
 		await expect(resultsView.summaryTab).toBeChecked()
 		await expect(resultsView.responsesTab).not.toBeChecked()
-		await expect(resultsView.page).toHaveURL(/\/results\?view=summary$/)
+		await expect(resultsView.page).toHaveURL(/\/results\/summary$/)
 	})
 
-	test('Explicit query route wins over remembered localStorage view', async ({
-		page,
-		resultsView,
-	}) => {
-		await page.evaluate(() => {
-			const match = window.location.pathname.match(
-				/\/apps\/forms\/([^/]+)\/results$/,
-			)
-			if (!match) {
-				throw new Error('Expected results route before setting localStorage')
-			}
-
-			localStorage.setItem(
-				`nextcloud_forms_${match[1]}_activeResponseView`,
-				'responses',
-			)
-		})
-
-		await page.goto(page.url().replace(/\/results.*$/, '/results?view=summary'))
-		await page.waitForURL(/\/results\?view=summary$/)
-
-		await expect(resultsView.summaryTab).toBeChecked()
-		await expect(resultsView.responsesTab).not.toBeChecked()
-	})
+	test('Navigating to /results redirects to /results/summary', async ({ page }) => {
+		// Start on the responses tab
+		await page.goto(page.url().replace(/\/summary$/, '/responses'))
+		await page.waitForURL(/\/results\/responses$/)
 
-	test('Query-less results route restores the remembered localStorage view', async ({
-		page,
-		resultsView,
-	}) => {
-		await page.evaluate(() => {
-			const match = window.location.pathname.match(
-				/\/apps\/forms\/([^/]+)\/results$/,
-			)
-			if (!match) {
-				throw new Error('Expected results route before setting localStorage')
-			}
-
-			localStorage.setItem(
-				`nextcloud_forms_${match[1]}_activeResponseView`,
-				'responses',
-			)
-		})
-
-		await page.goto(page.url().replace(/\/results.*$/, '/results'))
-		await page.waitForURL(/\/results\?view=responses$/)
-
-		await expect(resultsView.responsesTab).toBeChecked()
-		await expect(resultsView.summaryTab).not.toBeChecked()
+		// Navigate to the parent results route
+		await page.goto(page.url().replace(/\/responses$/, ''))
+		await page.waitForURL(/\/results\/summary$/)
+		await expect(page).toHaveURL(/\/results\/summary$/)
 	})
 })
+

playwright/support/sections/SubmitSection.ts

@@ -13,9 +13,10 @@ export class SubmitSection {
 	constructor(public readonly page: Page) {
 		this.clearFormButton = this.page.getByRole('button', { name: 'Clear form' })
 		this.submitButton = this.page.getByRole('button', { name: 'Submit' })
-		this.successMessage = this.page.getByText(
-			'Thank you for completing the form!',
-		)
+		this.successMessage = this.page
+			.getByRole('main')
+			.locator('.forms-emptycontent')
+			.getByText('Thank you for completing the form!')
 	}
 
 	/**