fix: bound media search and backfill requests - #4273
Merged
Conversation
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Use a fixed 1,000-item cap because Nextcloud cannot range-filter display names for same-date results. Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
Signed-off-by: Marino Faggiana <marino.faggiana@nextcloud.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4255 by replacing effectively unbounded media WebDAV searches with bounded requests.
This PR introduces two changes:
Backfill behavior
Known limitation
Nextcloud WebDAV SEARCH supports sorting by displayname, but does not support range comparisons such as lte for that field. Pagination therefore cannot use a composite date-and-filename cursor.
If at least 1,000 media items share the exact same cursor date, the backfill stops safely instead of entering an infinite loop. A future background task may encounter the same boundary again, but existing items remain protected by ocId deduplication.
馃 AI (if applicable)