fix: pass language to Collabora file conversions - #5973
Conversation
Fixes nextcloud#5165 Signed-off-by: xhon-pelushi <xhon@pelushi.com>
1e7d66e to
767e2da
Compare
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
|
Thank you for working on this @xhon-pelushi. That you want to work on the richdocuments app means a lot. <3 I do have some feedback that I think is worth considering: In That said, I have not totally tested this PR yet, but given that it works as intended I am happy to merge it in the meantime and we can create a separate issue for refactoring that bit. But if you want to already take the opportunity to take care of that, that's also fine. Will give it a proper test soon. |
Summary
langparameter.Fixes #5165
Test plan
composer run test:unitfor the new conversion tests when PHP tooling is available.