Skip to content

fix(federation): use share owner - #63316

Open
ArtificialOwl wants to merge 2 commits into
masterfrom
fix/noid/share-owner-on-federated
Open

fix(federation): use share owner#63316
ArtificialOwl wants to merge 2 commits into
masterfrom
fix/noid/share-owner-on-federated

Conversation

@ArtificialOwl

@ArtificialOwl ArtificialOwl commented Aug 17, 2026

Copy link
Copy Markdown
Member

In case of federated/remote share (type=6):

  • in case of single federated share, the share owner and sharedby are the same,
  • In case of reshare of a federated share, the share owner is the correct value and sharedby is a remote account, making getUserFolder to fail,
  • In case of a reshare of a local share, sharedby should still work and the share owner is the original share owner,
  • In case of a federated reshare of a local reshare, shareowner is the original share owner and sharedby is a remote account -> fail.

This patch enforce the use of shareowner for every remote instance reaching details about a federated share

@ArtificialOwl

ArtificialOwl commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

/backport to stable34

@ArtificialOwl

ArtificialOwl commented Aug 17, 2026

Copy link
Copy Markdown
Member Author

/backport to stable33

@ArtificialOwl
fix(federation): use share owner
075d9c5 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
@ArtificialOwl
ArtificialOwl force-pushed the fix/noid/share-owner-on-federated branch from 6ee1ddd to 075d9c5 Compare August 17, 2026 11:42
@ArtificialOwl
ArtificialOwl marked this pull request as ready for review August 17, 2026 11:42
@ArtificialOwl
ArtificialOwl requested a review from a team as a code owner August 17, 2026 11:42
@ArtificialOwl
ArtificialOwl requested review from Altahrim, CarlSchwan, icewind1991 and salmart-dev and removed request for a team August 17, 2026 11:42
@ArtificialOwl ArtificialOwl added the 3. to review Waiting for reviews label Aug 17, 2026
@ArtificialOwl ArtificialOwl added this to the Nextcloud 35 milestone Aug 17, 2026
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 18, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 20, 2026
Merged
@skjnldsv skjnldsv mentioned this pull request Aug 25, 2026
Merged
@nextcloud-bot nextcloud-bot mentioned this pull request Aug 27, 2026
Merged
@joshtrichards
refactor(dav): clarify public share user selection
e4ab50b 
Signed-off-by: Josh <josh.t.richards@gmail.com>
@joshtrichards joshtrichards added bug feature: sharing feature: federation 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Aug 28, 2026
@joshtrichards

joshtrichards commented Aug 28, 2026

Copy link
Copy Markdown
Member

/backport to stable35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes
@CarlSchwan CarlSchwan CarlSchwan approved these changes
@icewind1991 icewind1991 Awaiting requested review from icewind1991 icewind1991 is a code owner automatically assigned from nextcloud/server-backend
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend

Assignees

No one assigned

Labels

4. to release Ready to be released and/or waiting for tests to finish backport-request bug feature: federation feature: sharing

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@ArtificialOwl @joshtrichards @CarlSchwan