-
-
Notifications
You must be signed in to change notification settings - Fork 317
fix(call): detect dead signaling WebSocket connections via ping interval #6543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+66
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55 changes: 55 additions & 0 deletions
55
app/src/test/java/com/nextcloud/talk/webrtc/WebSocketInstanceSignalingClientTest.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| /* | ||
| * Nextcloud Talk - Android Client | ||
| * | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: GPL-3.0-or-later | ||
| */ | ||
| package com.nextcloud.talk.webrtc | ||
|
|
||
| import okhttp3.OkHttpClient | ||
| import org.junit.Assert.assertEquals | ||
| import org.junit.Assert.assertNotSame | ||
| import org.junit.Test | ||
| import java.util.concurrent.TimeUnit | ||
|
|
||
| /** | ||
| * Tests for the signaling WebSocket client configuration ([WebSocketInstance.createSignalingHttpClient]). | ||
| * | ||
| * Without a ping interval OkHttp sends no protocol-level pings on WebSockets and uses an infinite read timeout, | ||
| * so a half-open connection (e.g. after a WiFi to cellular switch without a TCP reset) is never detected: the | ||
| * reconnect path via "onFailure" never runs and the call goes silently mute/deaf. These tests pin the ping | ||
| * configuration that makes dead connections fail fast. | ||
| */ | ||
| class WebSocketInstanceSignalingClientTest { | ||
|
|
||
| @Test | ||
| fun signalingClientHasPingIntervalConfigured() { | ||
| val signalingClient = WebSocketInstance.createSignalingHttpClient(OkHttpClient()) | ||
|
|
||
| // hardcoded on purpose: fails if the ping interval in WebSocketInstance changes or is removed | ||
| assertEquals( | ||
| "signaling WebSocket client must send pings to detect half-open connections", | ||
| 10_000, | ||
| signalingClient.pingIntervalMillis | ||
| ) | ||
| } | ||
|
|
||
| @Test | ||
| fun signalingClientIsDerivedFromBaseClientWithoutMutatingIt() { | ||
| val baseClient = OkHttpClient.Builder() | ||
| .connectTimeout(45, TimeUnit.SECONDS) | ||
| .readTimeout(45, TimeUnit.SECONDS) | ||
| .build() | ||
|
|
||
| val signalingClient = WebSocketInstance.createSignalingHttpClient(baseClient) | ||
|
|
||
| assertNotSame("a dedicated client instance must be used", baseClient, signalingClient) | ||
| assertEquals( | ||
| "base client (shared with regular HTTP calls) must stay unchanged", | ||
| 0, | ||
| baseClient.pingIntervalMillis | ||
| ) | ||
| assertEquals(baseClient.connectTimeoutMillis, signalingClient.connectTimeoutMillis) | ||
| assertEquals(baseClient.readTimeoutMillis, signalingClient.readTimeoutMillis) | ||
| } | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.