Add float waveform support to the Python API - #166
Merged
Conversation
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for single-precision (float32/complex64) waveform types to the DataStore Python API by extending gRPC conversion paths and expanding unit/acceptance coverage, along with dependency bumps to pick up the new protobuf surface area.
Changes:
- Add float32/complex64 waveform (AnalogWaveform, ComplexWaveform, Spectrum) gRPC publish/read conversion support.
- Expand unit tests for read-path dtype/value handling and publish request population.
- Update acceptance tests for publishing/reading float waveforms; bump related protobuf/client dependencies.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/ni/datastore/data/_grpc_conversion.py |
Adds float waveform branches for publish request population and read response conversion. |
src/ni/datastore/data/_data_store_client.py |
Updates publish_measurement docstring to mention float waveform support. |
tests/unit/data/test_read.py |
Adds unit tests for reading float waveform variants and dtype assertions. |
tests/unit/data/test_grpc_conversion.py |
Adds unit tests ensuring float waveform types populate the correct protobuf fields. |
tests/acceptance/test_publish_measurement_and_read_data.py |
Adds/renames acceptance tests for publishing and reading float analog/complex waveforms. |
pyproject.toml |
Bumps dependencies to versions that include float waveform protos/converters. |
poetry.lock |
Locks updated dependency versions and hashes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
marked this pull request as draft
August 6, 2026 14:03
…t. Fix acceptance test names. Fix unit tests. Signed-off-by: Michael Johansen <michael.johansen@emerson.com>
mjohanse-emr
marked this pull request as ready for review
August 6, 2026 14:14
dixonjoel
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Add support for the three new float waveform types:
For each of these types:
To do this, I had to update the following dependencies to pull in float waveform support:
Why should this Pull Request be merged?
AB#3985023
AB#3985045
We want to expose the float waveform types to clients who use our Python API.
What testing has been done?