feat(docs): add documentation for doc-kit#889
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #889 +/- ##
==========================================
- Coverage 85.04% 83.87% -1.18%
==========================================
Files 179 183 +4
Lines 16496 16826 +330
Branches 1500 1513 +13
==========================================
+ Hits 14029 14112 +83
- Misses 2457 2704 +247
Partials 10 10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
| File | Base | Head | Diff |
|---|---|---|---|
all.html |
19.94 MB | 19.94 MB | -234.00 B (-0.00%) |
AugustinMauroy
left a comment
There was a problem hiding this comment.
Noice !
also we should add a "why doc-kit" section but with a "TBD" and in future have comparison with fuma-docs/docausorus ...
There was a problem hiding this comment.
if I recall correctly on this file we can customize the color theme.
And IMO we should change it. Why not keep green ? this green will be understood as nodejs runtime related. so for undici, learn it's work well. But if we want to as general propose tool we should chose another colors.
Also it's good example of how can this be customized.
| - name: Upload site artifact | ||
| uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1 | ||
| with: | ||
| name: docs-site | ||
| path: www/out |
There was a problem hiding this comment.
what if we deploy the docs on GH page ?
There was a problem hiding this comment.
i dont have strong opinions here other that continuing our current patterns.
PR SummaryLow Risk Overview A new Authoring includes new home and getting-started pages and a custom Reviewed by Cursor Bugbot for commit 3f035e7. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
|
||
| node bin/cli.mjs generate \ | ||
| --config-file ./www/doc-kit.config.mjs \ | ||
| --log-level info |
There was a problem hiding this comment.
Build script ignores content failure
High Severity
The docs build shell script runs content assembly and doc-kit generate as separate commands without failing fast. If build-docs-content.mjs exits non-zero, the generator still runs, so node --run docs:build and CI can succeed with missing or stale www/content/.
Reviewed by Cursor Bugbot for commit 0f9fb0f. Configure here.
| links: [], | ||
| html: [], | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Node banner on doc-kit site
Medium Severity
The documentation site config customizes web branding but leaves the default remoteConfigUrl pointing at nodejs.org. The layout still loads remote Node.js announcement banners on the doc-kit docs site instead of a neutral or empty banner config.
Reviewed by Cursor Bugbot for commit 0f9fb0f. Configure here.
| * | ||
| * @returns {Promise<Array<{ name: string, markdown: string }>>} | ||
| */ | ||
| const collectPages = async () => { |
There was a problem hiding this comment.
Would it be better to use a glob for this?
**/*.md?
There was a problem hiding this comment.
i dont have strong opinions either way, but knew that i
- wanted to clean
out - load very specific subset of three possible patterns, but perhaps not other future markdown.
| The `legacy-html-all` target has no additional dependencies and is the quickest | ||
| way to see output: |
There was a problem hiding this comment.
What does "no additional dependencies" mean? It depends on other generators (e.g. AST)
There was a problem hiding this comment.
to run in the browser. it's html
| - [Further customize the `web` generator](./generator-web) — check out more | ||
| customization options | ||
| - [Read the full input specification](./specification) — the full Markdown | ||
| contract. components. |
There was a problem hiding this comment.
lol can you tell i am typing this while watching the world cup?
| // Pages are assembled into `www/content/` at build time, so there is no | ||
| // single source file a `{path}` template could point at. Link to the repo | ||
| // instead; a per-page link would need a `#theme/Metabar` override that maps | ||
| // each slug back to its true origin. | ||
| editURL: `https://github.com/${REPOSITORY}`, |
There was a problem hiding this comment.
We can also leave this blank to remove the link entirely
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Aviv Keller <me@aviv.sh>
Co-authored-by: Aviv Keller <me@aviv.sh>
|
|
||
| await Promise.all( | ||
| pages.map(({ name, markdown }) => writeFile(join(CONTENT, name), markdown)) | ||
| ); |
There was a problem hiding this comment.
Silent duplicate content filenames
Medium Severity
collectPages merges www/pages, docs, and generator READMEs into one list keyed only by basename. Two sources with the same .md filename write to one path with no warning; whichever write finishes last wins and the other source’s page disappears from the built site.
Reviewed by Cursor Bugbot for commit b714583. Configure here.
Co-authored-by: Aviv Keller <me@aviv.sh>
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
There are 4 total unresolved issues (including 3 from previous reviews).
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3f035e7. Configure here.
There was a problem hiding this comment.
missing link to orama docs



Description
Introduces the doc-kit documentation site, built with doc-kit!
This also serves as a reasonable simple
webexample.Validation
Getting started suggestion end-state
Related Issues
Check List
node --run testand all tests passed.node --run format&node --run lint.