sqlite: refactor error helpers and user function pointers

[thisalihassan]

Two small independent refactors.

1. Consolidate CreateSQLiteError overloads
2. BaseObjectWeakPtr for user functions (style consistency)

[nodejs-github-bot]

Review requested:

• @nodejs/sqlite

[codecov]

Codecov Report

❌ Patch coverage is 88.88889% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.14%. Comparing base (54a5095) to head (fe5a33c).
⚠️ Report is 179 commits behind head on main.

Files with missing lines	Patch %	Lines
src/node_sqlite.cc	88.88%	1 Missing and 3 partials ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #62794   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files         744      744           
  Lines      242518   242500   -18     
  Branches    45685    45683    -2     
=======================================
- Hits       218611   218606    -5     
+ Misses      15396    15390    -6     
+ Partials     8511     8504    -7     

Files with missing lines	Coverage Δ
src/node_sqlite.h	80.64% <ø> (ø)
src/node_sqlite.cc	80.72% <88.88%> (+0.05%)	⬆️

... and 22 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[thisalihassan]

@nodejs/sqlite @geeksilva97 can I get a review please?

[geeksilva97]

Sure. Will take a look.

[geeksilva97]

cc @nodejs/cpp-reviewers

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/73204/

[trivikr]

Is this okay to land @geeksilva97, or do we need an additional review from CPP team?

[geeksilva97]

Is this okay to land @geeksilva97, or do we need an additional review from CPP team?

PR LGTM. We can get it landed, I was just looking for another eye before moving further.

We need a new CI run since it's been a while

[thisalihassan]

@geeksilva97 @trivikr do I need to rebase or something?

[geeksilva97]

@geeksilva97 @trivikr do I need to rebase or something?

yes, please

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/75554/

[trivikr]

There are errors thrown during compilation

error: no matching constructor for initialization of 'CallbackDepthGuard'
note: no known conversion from 'BaseObjectWeakPtr<DatabaseSync>'
      to 'DatabaseSync *'

The fix is likely going to be explicitly passing the stored pointer at the three locations

- CallbackDepthGuard guard(self->db_);
+ CallbackDepthGuard guard(self->db_.get());

@thisalihassan Can you fix this in a commit and push?

[thisalihassan]

Thanks @trivikr let me check

[thisalihassan]

@trivikr I have fixed the compliation issue, but the CI is red due to infra outages
cc: @geeksilva97