stream: fix drop-newest behavior in share()#64417
Open
trivikr wants to merge 1 commit into
Open
Conversation
Discard upstream pull results when the shared buffer has reached its highWaterMark instead of allowing the buffer to grow beyond its limit. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com>
Collaborator
|
Review requested:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #64417 +/- ##
=======================================
Coverage 90.23% 90.23%
=======================================
Files 741 741
Lines 241339 241339
Branches 45464 45474 +10
=======================================
+ Hits 217766 217780 +14
+ Misses 15132 15122 -10
+ Partials 8441 8437 -4
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #64416
Fixes
share()withbackpressure: 'drop-newest'so upstream pullresults are discarded when the shared buffer reaches
highWaterMark.Previously,
#waitForBufferSpace()returnedtruefordrop-newest,causing the pulled batch to be appended to the full buffer. The buffer
could therefore grow beyond
highWaterMark, and stalled consumerseventually received every batch.
The async implementation now pulls and discards new results while the
buffer is full. The existing test has been updated to verify that the
buffer remains bounded and dropped batches are not delivered.