http: use env proxy when agent has no proxyEnv option#64528
Open
swigger wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
http
mcollina
requested changes
Jul 16, 2026
mcollina
left a comment
mcollina
left a comment
Member
There was a problem hiding this comment.
Thanks for opening a PR! Can you please add a unit test?
swigger
force-pushed
the
http-agent-use-env-proxy
branch
from
July 17, 2026 07:53
5166481 to
19d1924
Compare
Author
now I refreshed the PR and a unit test included. |
Member
|
@joyeecheung I think this is a bugfix, but an argument could be made this is semver-major. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #64528 +/- ##
=======================================
Coverage 90.24% 90.24%
=======================================
Files 739 739
Lines 241669 241701 +32
Branches 45543 45553 +10
=======================================
+ Hits 218087 218130 +43
+ Misses 15150 15100 -50
- Partials 8432 8471 +39
🚀 New features to boost your workflow:
|
swigger
force-pushed
the
http-agent-use-env-proxy
branch
from
July 20, 2026 06:59
19d1924 to
fc4352d
Compare
Member
|
joyeecheung
reviewed
Jul 20, 2026
joyeecheung
left a comment
joyeecheung
left a comment
Member
There was a problem hiding this comment.
Can you update the documentation to clarify the behavior?
When a user creates a custom agent without specifying proxyEnv but
Node.js is configured to use a proxy from the environment (via
--use-env-proxy or NODE_USE_ENV_PROXY), fall back to process.env.
A developer can still explicitly disable proxying for an agent even
when Node.js is configured to use a proxy at runtime, by passing a
falsy proxyEnv explicitly. For example:
const agent = new https.Agent({ proxyEnv: null });
Signed-off-by: swigger <swigger@gmail.com>
swigger
force-pushed
the
http-agent-use-env-proxy
branch
from
July 21, 2026 02:12
fc4352d to
1a701f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a user creates a custom agent without specifying proxyEnv but Node.js is configured to use a proxy from the environment (via --use-env-proxy or NODE_USE_ENV_PROXY), fall back to process.env.
A developer can still explicitly disable proxying for an agent even when Node.js is configured to use a proxy at runtime, by passing a falsy proxyEnv explicitly. For example: