Skip to content

deps: V8: backport 2d837cbc1ca2#64631

Open
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:v8-backport-8123081
Open

deps: V8: backport 2d837cbc1ca2#64631
avivkeller wants to merge 1 commit into
nodejs:mainfrom
avivkeller:v8-backport-8123081

Conversation

@avivkeller

Copy link
Copy Markdown
Member

Blocked by https://chromium-review.googlesource.com/c/v8/v8/+/8123081

Original commit message:

fix(inspector): hold on to `replMode: true` promises

Keep `m_evaluationResult` strong for `replMode: true` evaluations
until the promise settles or the request is cancelled.

Bug: 536271637
Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207

Refs: v8/v8@2d837cb

@avivkeller avivkeller added the blocked PRs that are blocked by other issues or PRs. label Jul 20, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/gyp
  • @nodejs/security-wg
  • @nodejs/v8-update

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Jul 20, 2026
@avivkeller avivkeller linked an issue Jul 20, 2026 that may be closed by this pull request
Original commit message:

    fix(inspector): hold on to `replMode: true` promises

    Keep `m_evaluationResult` strong for `replMode: true` evaluations
    until the promise settles or the request is cancelled.

    Bug: 536271637
    Change-Id: If21cc4aa0ba6bb2e2722d5ee73eb7744a0ead207

Refs: v8/v8@2d837cb
Co-authored-by: avivkeller <me@aviv.sh>
@avivkeller
avivkeller force-pushed the v8-backport-8123081 branch from 3f332e4 to 2ec3540 Compare July 20, 2026 16:32
@legendecas

Copy link
Copy Markdown
Member

CI failure seems related to #64633.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test/parallel/test-repl-user-error-handler is flaky

3 participants