Skip to content

src: require watchdog status pointers #64667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Archkon wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −5
Open

src: require watchdog status pointers #64667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/node_watchdog.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ using v8::Value;

Watchdog::Watchdog(v8::Isolate* isolate, uint64_t ms, bool* timed_out)
: isolate_(isolate), timed_out_(timed_out) {
CHECK_NOT_NULL(timed_out);

int rc;
rc = uv_loop_init(&loop_);
Expand Down Expand Up @@ -103,6 +104,7 @@ void Watchdog::Timer(uv_timer_t* timer) {
SigintWatchdog::SigintWatchdog(
v8::Isolate* isolate, bool* received_signal)
: isolate_(isolate), received_signal_(received_signal) {
CHECK_NOT_NULL(received_signal);
Mutex::ScopedLock lock(SigintWatchdogHelper::GetInstanceActionMutex());
// Register this watchdog with the global SIGINT/Ctrl+C listener.
SigintWatchdogHelper::GetInstance()->Register(this);
Expand Down
7 changes: 2 additions & 5 deletions src/node_watchdog.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,7 @@ enum class SignalPropagation {

class Watchdog {
public:
explicit Watchdog(v8::Isolate* isolate,
uint64_t ms,
bool* timed_out = nullptr);
explicit Watchdog(v8::Isolate* isolate, uint64_t ms, bool* timed_out);
Comment thread
Archkon marked this conversation as resolved.
~Watchdog();
v8::Isolate* isolate() { return isolate_; }

Expand Down Expand Up @@ -75,8 +73,7 @@ class SigintWatchdogBase {

class SigintWatchdog : public SigintWatchdogBase {
public:
explicit SigintWatchdog(v8::Isolate* isolate,
bool* received_signal = nullptr);
explicit SigintWatchdog(v8::Isolate* isolate, bool* received_signal);
~SigintWatchdog();
v8::Isolate* isolate() { return isolate_; }
SignalPropagation HandleSigint() override;
Expand Down
Loading