[v24.x backport] `node:stream/iter` and QUIC backports by aduh95 · Pull Request #64675 · nodejs/node

aduh95 · 2026-07-22T11:54:54Z

Backport of:

nodejs-github-bot · 2026-07-22T11:55:00Z

Review requested:

codecov · 2026-07-22T20:38:39Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (b881658) to head (65439dd).
⚠️ Report is 432 commits behind head on v24.x-staging.

Additional details and impacted files

@@                Coverage Diff                @@
##           v24.x-staging   #64675      +/-   ##
=================================================
+ Coverage          89.92%   90.23%   +0.31%     
=================================================
  Files                686      710      +24     
  Lines             208389   226450   +18061     
  Branches           40077    42776    +2699     
=================================================
+ Hits              187387   204341   +16954     
- Misses             13238    14100     +862     
- Partials            7764     8009     +245

see 273 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

nodejs-github-bot · 2026-07-24T10:52:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75090/

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

On the client, add verifyPeer: 'auto', 'strict', and 'manual' modes. The 'strict' mode will reject invalid certs at the handshake layer, while the 'manual' mode allows the application to inspect the peer cert and decide whether to trust it or not. The 'auto' mode is the default and will reject invalid certs at a middle layer after the onhandshake event. Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode:Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63198 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63536 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63874 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>

Implements a callback that is invoked once http/3 settings are received. Background, http/3 settings usually arrive a bit later than connection establishment, and e.g. for webtransport these settings are used to indicate support. So e.g. the examples for quiche from google, wait for the settings to arrive. (This is different to http/2). The implemented callback mechanism allows to wait for the settings to arrive until connection attempts are made. As settings are stored in the generic applications option object, the callback's name refers to the application rather than the settings. Whether this is a good choice is debatable. Fixes: nodejs#63553 Signed-off-by: Marten Richter <marten.richter@freenet.de> PR-URL: nodejs#63558 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63191 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63946 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

If the #handle is undefined and not QuicStream, while kInspect is called `DataViewPrototypeGetByteLength` will throw. Signed-off-by: Marten Richter <marten.richter@freenet.de> PR-URL: nodejs#64170 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Tim Perry <pimterry@gmail.com>

Signed-off-by: Mohamed Sayed <k@3zrv.com> PR-URL: nodejs#64228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Document that duck-typed readable inputs must provide off() in addition to read() and on(), matching the cleanup behavior in the implementation. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> PR-URL: nodejs#63682 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>

This notable includes stream/iter (since they're closely related and rapidly evolving together) and ngtcp2, nghttp3 & openssl deps. Based on test-linux.yml, the main differences are simplifications: PRs only, filtered to specific paths, just one build (ARM only), no unusual characters test. Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63875 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: nodejs#64043 Refs: nodejs#63078 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot · 2026-08-03T18:41:46Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75440/

Renegade334 · 2026-08-04T17:11:00Z

The linker errors seem to suggest that it's nghttp2 (not nghttp3) which is clashing with itself: we build nghttp2/lib/sfparse.c as part of the nghttp2 target, but also build it as a standalone sfparse target to use as a static library in the test implementations (whose builds we have deliberately disabled).

We can either look for a definitive fix... or just remove the disabled test implementation targets from ngtcp2.gyp and the associated sfparse target from nghttp2.gyp for v24.x, given that we are never ever going to be building these for the lifetime of v24.x due to the C++23 requirement. (To that end, does removing d2207f8 fix the linker errors?)

aduh95 · 2026-08-04T21:49:56Z

To that end, does removing d2207f8 fix the linker errors?

It's hard to tell, all the changes build on top of it so it's very hard to remove

Renegade334 · 2026-08-04T22:14:59Z

Worth trying a CI run with b36adcb on top?

aduh95 · 2026-08-04T22:20:33Z

https://ci.nodejs.org/job/node-test-commit-linux-containered/57918/

Renegade334 · 2026-08-04T23:17:29Z

Interesting...

Not sure if related, but I've noticed that the node.gypi changes from the backported #59946 are overlapping with #61444 (a later PR, but already merged to v24.x) – the latter removed the ngtcp2 targets from the openssl section of node.gypi and moved them elsewhere, the backport is adding them back in, so they're now duplicated. Those test implementations are the only build targets that depend on nghttp2:sfparse... 🤔

Worth trying 04e036a to fixup that commit?

aduh95 · 2026-08-05T08:37:35Z

https://ci.nodejs.org/job/node-test-commit-linux-containered/57931/

nodejs-github-bot · 2026-08-05T08:59:30Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75510/

nodejs-github-bot · 2026-08-05T13:45:57Z

CI: https://ci.nodejs.org/job/node-test-pull-request/75523/

aduh95 requested a review from a team as a code owner July 22, 2026 11:54

aduh95 added the semver-minor PRs that contain new features and should be released in the next minor version. label Jul 22, 2026

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 22, 2026

aduh95 marked this pull request as draft July 22, 2026 11:55

aduh95 force-pushed the stream-iter-and-quic-backports branch from 935ead8 to 1a1c988 Compare July 22, 2026 11:57

aduh95 marked this pull request as ready for review July 22, 2026 11:57

aduh95 marked this pull request as draft July 22, 2026 11:58

aduh95 force-pushed the stream-iter-and-quic-backports branch from 1a1c988 to 975ed7b Compare July 22, 2026 11:58

aduh95 marked this pull request as ready for review July 22, 2026 11:59

aduh95 marked this pull request as draft July 22, 2026 11:59

aduh95 force-pushed the stream-iter-and-quic-backports branch from 975ed7b to 2b26bbe Compare July 22, 2026 12:00

aduh95 marked this pull request as ready for review July 22, 2026 12:00

aduh95 force-pushed the stream-iter-and-quic-backports branch 4 times, most recently from b28dcf7 to 3c553ff Compare July 22, 2026 13:32

aduh95 changed the base branch from v24.19.0-proposal to v24.x-staging July 22, 2026 13:33

aduh95 marked this pull request as draft July 22, 2026 13:33

aduh95 marked this pull request as ready for review July 22, 2026 13:33

aduh95 force-pushed the stream-iter-and-quic-backports branch from 3c553ff to 173b666 Compare July 22, 2026 13:37

aduh95 force-pushed the v24.x-staging branch from df905c5 to 4e90b7a Compare July 22, 2026 13:43

aduh95 force-pushed the stream-iter-and-quic-backports branch 3 times, most recently from 7e7fa1a to 182db6c Compare July 22, 2026 15:53

aduh95 force-pushed the stream-iter-and-quic-backports branch 2 times, most recently from c1ef609 to 421ba7e Compare July 24, 2026 09:13

juanarbol force-pushed the v24.x-staging branch from 4e90b7a to 9623d9a Compare July 29, 2026 14:04

jasnell and others added 19 commits August 3, 2026 20:33

quic: add rate limiting docs

3df9b8b

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

quic: handle h3 max header size option

8d9a6a1

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

quic: add block list support for endpoints

ba3f581

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

quic: add stream idle timeout

6fbb29b

Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode:Opus 4.6 PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

quic: support hostname verification

1aaa660

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63483 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

quic: add proper error codes & messages for QUIC failures

fdb08c6

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63198 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

quic: add listEndpoints API

b3e34ff

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#63536 Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

quic: fix reader backpressure deadlock on idle connections

bd9c68d

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63950 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

quic: fix get_reader bug that dropped data on FIN

1b97611

Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: nodejs#63946 Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>

quic: drop version negotiation packets with oversized CIDs

dfc82af

Signed-off-by: Mohamed Sayed <k@3zrv.com> PR-URL: nodejs#64228 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

doc: remove unsupported syntax from stream_iter.md

7ceca3b

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com> PR-URL: nodejs#64649 Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Aviv Keller <me@aviv.sh>

aduh95 force-pushed the stream-iter-and-quic-backports branch from 2dd39a0 to e11cdce Compare August 3, 2026 18:38

fixup! deps: add ngtcp2 test binaries

65439dd

Navigation Menu

Uh oh!

Uh oh!

[v24.x backport] `node:stream/iter` and QUIC backports - #64675

[v24.x backport] `node:stream/iter` and QUIC backports#64675
aduh95 wants to merge 118 commits into
nodejs:v24.x-stagingfrom
aduh95:stream-iter-and-quic-backports

aduh95 commented Jul 22, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jul 22, 2026

Uh oh!

codecov Bot commented Jul 22, 2026 •

edited

Loading

Uh oh!

nodejs-github-bot commented Jul 24, 2026

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

Renegade334 commented Aug 4, 2026

Uh oh!

aduh95 commented Aug 4, 2026

Uh oh!

Renegade334 commented Aug 4, 2026

Uh oh!

aduh95 commented Aug 4, 2026

Uh oh!

Renegade334 commented Aug 4, 2026 •

edited

Loading

Uh oh!

aduh95 commented Aug 5, 2026

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

Uh oh!

Uh oh!

Conversation

aduh95 commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nodejs-github-bot commented Jul 22, 2026

Uh oh!

codecov Bot commented Jul 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

nodejs-github-bot commented Jul 24, 2026

Uh oh!

nodejs-github-bot commented Aug 3, 2026

Uh oh!

Renegade334 commented Aug 4, 2026

Uh oh!

aduh95 commented Aug 4, 2026

Uh oh!

Renegade334 commented Aug 4, 2026

Uh oh!

aduh95 commented Aug 4, 2026

Uh oh!

Renegade334 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aduh95 commented Aug 5, 2026

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

nodejs-github-bot commented Aug 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

aduh95 commented Jul 22, 2026 •

edited

Loading

codecov Bot commented Jul 22, 2026 •

edited

Loading

Renegade334 commented Aug 4, 2026 •

edited

Loading