Skip to content

process: reject null bytes in chdir paths - #65068

Open
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process2
Open

process: reject null bytes in chdir paths#65068
Archkon wants to merge 1 commit into
nodejs:mainfrom
Archkon:process2

Conversation

@Archkon

@Archkon Archkon commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Validate directory strings before calling the native chdir binding to prevent paths from being truncated at embedded null bytes.

Validate directory strings before calling the native chdir binding to
prevent paths from being truncated at embedded null bytes.

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Aug 6, 2026
@codecov

codecov Bot commented Aug 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (c18fd90) to head (bebc86d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65068      +/-   ##
==========================================
- Coverage   90.31%   90.30%   -0.01%     
==========================================
  Files         759      759              
  Lines      247646   247646              
  Branches    46697    46692       -5     
==========================================
- Hits       223654   223643      -11     
- Misses      15463    15472       +9     
- Partials     8529     8531       +2     
Files with missing lines Coverage Δ
...ernal/bootstrap/switches/does_own_process_state.js 95.13% <100.00%> (ø)

... and 32 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants