crypto: add mgf1Hash for RSA-OAEP - #65073
Open
adamjmcgrath wants to merge 2 commits into
Open
Conversation
nodejs-github-bot
added
needs-ci
Signed-off-by: Adam Mcgrath <adam.mcgrath@okta.com>
adamjmcgrath
force-pushed
the
add-mgf1hash
branch
from
August 6, 2026 08:25
425b745 to
2da33e7
Compare
adamjmcgrath
marked this pull request as ready for review
August 6, 2026 09:56
panva
added
commit-queue-squash
panva
added
author ready
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
crypto.publicEncrypt()andcrypto.privateDecrypt()expose only theoaepHashoption, which sets both the OAEP message digest and the MGF1 hash.As a result, Node cannot decrypt (or produce) an RSA-OAEP ciphertext where the OAEP digest and the MGF1 hash differ — e.g. OAEP digest = SHA-256, MGF1 = SHA-1.
OpenSSL exposes the two digests independently via
EVP_PKEY_CTX_set_rsa_oaep_mdandEVP_PKEY_CTX_set_rsa_mgf1_mdso this PR adds an mgf1Hash option that, when set, callsEVP_PKEY_CTX_set_rsa_mgf1_mdindependently of oaepHash.This is required to implement
http://www.w3.org/2001/04/xmlenc#rsa-oaep-mgf1pwhere the message digest can be configurable (e.g. SHA-256) but the mask generation function must be fixed to SHA-1.