doc: add missing added: tags to fs.lchmod - #65283
Open
lazerg wants to merge 2 commits into
Open
Conversation
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
nodejs-github-bot
added
doc
aduh95
reviewed
Aug 14, 2026
aduh95
reviewed
Aug 14, 2026
Signed-off-by: Lazizbek Ergashev <lazerg2@gmail.com>
aduh95
approved these changes
Aug 14, 2026
aduh95
added
author ready
|
Nice work — I independently traced the same source (v0.5.0 via nodejs/node-v0.x-archive#853) before noticing this PR. One possible follow-up: the existing |
Contributor
Author
|
Good catch, and yeah, that's the same rabbit hole. Turns out that one was already flagged in review, v0.4.7 predates fs.lchmod existing entirely (confirmed against CHANGELOG_ARCHIVE.md, fs.lchmod only shows up in v0.5.0 via #853). Already fixed it in this PR, deprecated now reads v0.5.0 too. No need for a separate issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The history dropdown for fs.lchmod, fs.lchmodSync, and fsPromises.lchmod only shows when each was deprecated, not when it was added. I traced the original addition through the v0.5.0 ChangeLog (issue nodejs/node-v0.x-archive#853) and the initial fs/promises implementation (#18297), and filled in the missing
added:version for each.Fixes: #65280
Refs: nodejs/node-v0.x-archive#853
Refs: 3935adc
Refs: #18297