src: remove experimental ShadowRealm support - #65650
Open
anonrig wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
cursor
Bot
force-pushed
the
cursor/remove-shadow-realm-09a0
branch
from
August 29, 2026 20:58
c7993ad to
50ef480
Compare
aduh95
added
experimental
The TC39 ShadowRealm proposal remains unimplemented by browsers, and WPT removed ShadowRealm test coverage. Remove the Node.js host integration, the --experimental-shadow-realm CLI flag, and related tests. Refs: web-platform-tests/wpt#59794 Refs: nodejs#42528 Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> Co-authored-by: Yagiz Nizipli <anonrig@users.noreply.github.com>
cursor
Bot
force-pushed
the
cursor/remove-shadow-realm-09a0
branch
from
August 29, 2026 22:05
50ef480 to
52ba7ce
Compare
jasnell
reviewed
Aug 29, 2026
jasnell
left a comment
jasnell
left a comment
Member
There was a problem hiding this comment.
While the status is still unclear, and it's not certain at all that'll it will make progress, it is still considered an active TC-39 proposal. Removing entirely may be premature. Won't block but I also don't agree with removing it just yet.
legendecas
approved these changes
Aug 29, 2026
Member
|
Technically the proposal was moved to stage 2.7, and not moved yet stage 3 back again for implementation. We could add it back when it gets promoted to stage 3 again. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65650 +/- ##
==========================================
- Coverage 91.79% 90.08% -1.72%
==========================================
Files 402 751 +349
Lines 181164 255588 +74424
Branches 27776 48292 +20516
==========================================
+ Hits 166308 230239 +63931
- Misses 14517 16490 +1973
- Partials 339 8859 +8520
🚀 New features to boost your workflow:
|
github-actions
Bot
removed
the
request-ci
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This removes experimental
ShadowRealmsupport from Node.js.The TC39 ShadowRealm proposal remains unimplemented by browsers. WPT dropped ShadowRealm test coverage in web-platform-tests/wpt#59794 because the tests added significant noise without implementer support.
This PR:
--experimental-shadow-realmflag and the--harmony-shadow-realmV8 option aliasnode_shadow_realm.*, isolate callback, bootstrap)--experimental-shadow-realmwas never enabled by default and never left experimental status.Refs: web-platform-tests/wpt#59794
Refs: #42528
This change was prepared with assistance from an AI coding agent.