Compute Web Bot Auth keyid via RFC 7638 thumbprint instead of jwt-eddsa's kid - #32
Merged
Conversation
…sa's kid
jwt-eddsa (<= 0.9.0) computes JWK::OKP's thumbprint over the wrong
members ({kty, n, x} instead of the RFC 8037-correct {crv, kty, x}),
so the Web Bot Auth `keyid` derived from it never matched what a
spec-compliant verifier expects.
Add Linzer::JWS::Key#jwk_thumbprint and use it instead, so Linzer
is correct independent of jwt/ruby-jwt-eddsa#26.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jwt-eddsa (<= 0.9.0) computes JWK::OKP's thumbprint over the wrong members ({kty, n, x} instead of the RFC 8037-correct {crv, kty, x}), so the Web Bot Auth
keyidderived from it never matched what a spec-compliant verifier expects.Add
Linzer::JWS::Key#jwk_thumbprintand use it instead, so Linzer is correct independent of jwt/ruby-jwt-eddsa#26.