chore(release): 0.14.6 — CI coverage-job flakefix + actions.cooldown race - #83
Merged
Merged
Conversation
…race - .github/workflows/ci.yml: install pytest-rerunfailures on the coverage job so the @pytest.mark.rerunfailures(reruns=2) marker on test_approval_timeout_field fires on the coverage leg too; pre-fix it was a silent no-op and the first spawn-vs-release race under -n auto on shared CI runners turned the run red even though the test (3.10/3.11/3.12) matrix was fully green. - tests/test_actions.py: TestPauseAction.test_is_paused_respects_cooldown sleeps 10ms between the PAUSE handle and the cooldown_seconds=0.0 assertion so elapsed = time.time() - paused_at > 0.0 deterministically; pre-fix the test was a pre-existing 0.13.7-era flake that became 5-in-5 on the 0.14.5 runner pool. Production is_paused unchanged. - pyproject.toml + src/nullrun/__version__.py: bump to 0.14.6 with v3.31.5 / 0.14.6 changelog entry covering both fixes. Verified locally: - pytest tests/ --ignore=tests/contract -> 1417 passed, 7 skipped - ruff check src/ tests/ -> All checks passed - mypy src/ -> Success: no issues found in 37 source files
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re-opened after PR #82 conflicted against origin/master (the original branch was based off a stale local master that lacked the 0.14.0-0.14.5 chain). This PR is based off origin/master @ 4878402 and contains only the four 0.14.6 changes.
Two CI-only fixes that surfaced as red runs on the 0.14.5 matrix:
coveragejob missingpytest-rerunfailures—.github/workflows/ci.yml:74. Thetestmatrix already installspytest-rerunfailures>=14.0,<16.0(lines 41-45); thecoveragejob did not. The@pytest.mark.rerunfailures(reruns=2)marker ontests/test_approval_timeout_field.py::TestApprovalTimeoutResolution::test_env_fallback_when_server_value_is_zerowas therefore a silent no-op on the coverage leg, and the first thread-scheduling race under-n autoon shared CI runners turned the run red even though all three test legs were green. Local sequential runs pass 15/15. Marker stays the same — only the plugin install on the coverage leg is added.test_is_paused_respects_cooldownwindow-of-zero race —tests/test_actions.py. Pre-existing 0.13.7-era flake that became 5-in-5 on the 0.14.5 runner pool. The test assertedis_paused(..., cooldown_seconds=0.0)returnsFalseimmediately after aPAUSE; the underlyingis_pausedcomputeselapsed = time.time() - paused_atand useselapsed > cooldown(strict greater-than). On any platform wheretime.time()rounds the same integer aspaused_atwithin the test body,elapsed == 0.0and the workflow stays "paused" forever. Test now sleeps0.01sbefore the post-cooldown assertion to make the check deterministic.ActionHandler.is_pausedsemantics unchanged.pyproject.toml+src/nullrun/__version__.pybumped to0.14.6(v3.31.5 / 0.14.6) with a changelog entry covering both fixes.uv.lockadded (lockfile was previously untracked; CI installs via pip so this is hygiene-only, but it keeps localuvinvocations deterministic for dev work).Verification (local, post-rebase)
pytest tests/ --ignore=tests/contract→ 1417 passed, 7 skipped in 44.11s (0 failures)ruff check src/ tests/→ All checks passedmypy src/→ Success: no issues found in 37 source filesNo public API change. No on-wire change. No SDK_MIN_VERSION bump.