ci: improve workflows - #1558
Conversation
| description: Nuxt module for vue-chrts | ||
| repo: dennisadriaans/vue-chrts#main/packages/nuxt-charts | ||
| npm: nuxt-charts | ||
| npm: nuxt-charts-legacy |
There was a problem hiding this comment.
I'm not sure why autofix added this?
📝 WalkthroughWalkthroughGitHub Actions workflows now define explicit checkout, Corepack, Node.js, and dependency installation steps. Autofix and CI add concurrency groups. CI and provenance disable checkout credential persistence. The agent-scan and provenance jobs switch to Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
.github/workflows/autofix.yml (1)
19-20: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the Corepack bootstrap version across workflows.
npm i -g --force corepackresolves a mutable version on every run, undermining the repository’s otherwise pinned package-manager setup. Pin a vetted Corepack version consistently:
.github/workflows/autofix.yml#L19-L20: usecorepack@<approved-version>..github/workflows/ci.yml#L26-L27: use the same exact Corepack version..github/workflows/release.yml#L25-L26: use the same exact Corepack version before publishing.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/autofix.yml around lines 19 - 20, Pin the Corepack bootstrap dependency to one approved version instead of installing the mutable latest version. Update the “Enable corepack” steps in .github/workflows/autofix.yml lines 19-20, .github/workflows/ci.yml lines 26-27, and .github/workflows/release.yml lines 25-26 to use the identical corepack@<approved-version> specification before enabling Corepack.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/provenance.yml:
- Around line 18-21: Update the Checkout step in the provenance workflow to
fetch the full repository history, including the origin/main ref required by
provenance comparison. Add the appropriate checkout configuration alongside
persist-credentials without changing the existing action pin or credential
behavior.
---
Nitpick comments:
In @.github/workflows/autofix.yml:
- Around line 19-20: Pin the Corepack bootstrap dependency to one approved
version instead of installing the mutable latest version. Update the “Enable
corepack” steps in .github/workflows/autofix.yml lines 19-20,
.github/workflows/ci.yml lines 26-27, and .github/workflows/release.yml lines
25-26 to use the identical corepack@<approved-version> specification before
enabling Corepack.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 06a47b2c-9db9-4bd4-b20d-e11176b275e4
📒 Files selected for processing (6)
.github/workflows/agent-scan.yml.github/workflows/autofix.yml.github/workflows/ci.yml.github/workflows/provenance.yml.github/workflows/release.ymlmodules/nuxt-charts.yml
64552c2 to
030ffcd
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/autofix.yml (1)
19-20: 🔒 Security & Privacy | 🔵 Trivial | ⚡ Quick winPin the Corepack bootstrap version.
npm i -g --force corepackinstalls Corepack without a version and defaults to thelatestdist tag. Pin this in.github/workflows/autofix.ymland the matching setup commands in other workflows, then verify the selected Corepack version works with the workflow Node versions.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/autofix.yml around lines 19 - 20, Pin the Corepack package version in the “Enable corepack” step instead of installing the unversioned latest release. Apply the same explicit version to matching Corepack setup commands in the other workflows, and verify that the pinned version supports each workflow’s configured Node.js version.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/autofix.yml:
- Around line 19-20: Pin the Corepack package version in the “Enable corepack”
step instead of installing the unversioned latest release. Apply the same
explicit version to matching Corepack setup commands in the other workflows, and
verify that the pinned version supports each workflow’s configured Node.js
version.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a17beff4-5de7-4c93-92a1-cc577d5ded1e
📒 Files selected for processing (5)
.github/workflows/agent-scan.yml.github/workflows/autofix.yml.github/workflows/ci.yml.github/workflows/provenance.yml.github/workflows/release.yml
🚧 Files skipped from review as they are similar to previous changes (4)
- .github/workflows/provenance.yml
- .github/workflows/release.yml
- .github/workflows/agent-scan.yml
- .github/workflows/ci.yml
🔗 Linked issue
📚 Description
ubuntu-slimrunnerUse it for
agent-scan.yml,provenance.yml, andci.yml— the lighter 1-vCPU runner reduces queue times and resource usage.Concurrency groups
Added to all PR-triggered workflows (
autofix.yml,ci.yml) so runs for the same PR/branch queue sequentially.cancel-in-progresswas intentionally omitted — GitHub's event system can fire duplicatepull_requestevents for a single push, andcancel-in-progress: truecaused those duplicates to cancel the legitimate run after 1 second. Runs now queue instead.persist-credentials: falseSet on
actions/checkoutinci.yml,release.yml, andprovenance.yml— none of those jobs perform subsequent git operations.autofix.ymlis intentionally excluded sinceautofix-ci/actionpushes lint fixes.Pre-install corepack
Use
npm i -g --force corepack && corepack enableinstead of relying on the bundled version, which will be removed in Node 26. The--forceflag is needed because the npm global prefix on Windows may already contain ayarnshim.Consistent formatting
Add blank lines between all steps and between all top-level keys across every workflow.