fix: strip CRLF from response header values - #14
Open
I3eg1nner wants to merge 1 commit into
Open
Conversation
Response headers pass user-controlled values to the HTTP layer without sanitizing \r\n. An attacker who controls a header value (e.g. via a redirect target or reflected parameter) can inject arbitrary headers (Set-Cookie, Cache-Control) or split the response. Add sanitize_header_value() and apply it at all three response paths: native, mongoose, and JS. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-controlled values written to response headers are not sanitized.
A POST body reflected into a Set-Cookie or custom header can inject
\r\n sequences, allowing HTTP response splitting.
Add sanitize_header_value() that strips CR/LF, and apply it in all
three backends (native, mongoose, JS) before writing headers and
cookies to the response.
Note: PRs #14, #15, #16 have been reviewed by GPT-5.6 sol to ensure code quality.
🤖 Generated with Claude Code