Fix declarative Jaeger sampler interval configuration - #8668
Open
abdessattar23 wants to merge 1 commit into
Open
Fix declarative Jaeger sampler interval configuration#8668abdessattar23 wants to merge 1 commit into
abdessattar23 wants to merge 1 commit into
Conversation
Pull request dashboard statusWaiting on reviewers · refreshed 2026-07-29 01:36 UTC Review the latest changes. Status above doesn't look right?
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8668 +/- ##
=========================================
Coverage 91.47% 91.48%
- Complexity 10458 10459 +1
=========================================
Files 1021 1021
Lines 27647 27652 +5
Branches 3242 3242
=========================================
+ Hits 25290 25297 +7
+ Misses 1616 1614 -2
Partials 741 741 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The declarative Jaeger remote sampler exposes its polling interval as
interval, but the provider readsinternal. This causes configured intervals to be ignored in favor of the default.This updates the key and adds regression coverage for configured and default intervals.
fixes #8648