fix: skip remote history for zero session limit - #4241
Closed
ump45nose wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for sharing the idea here, but I don't think this additional logic for limit: 0 use cases is necessary in real-world apps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request fixes
OpenAIConversationsSession.get_items()when the effective session history limit is zero.The Agents SDK session contract uses
limit=0to disable history retrieval, but this backend forwarded zero toconversations.items.list. The Conversations API only accepts limits from 1 to 100, so the call failed instead of returning no history. The method now resolves the effective limit before initializing a remote conversation and returns an empty list locally when it is zero.This preserves the existing behavior for positive limits and
None, and avoids creating an otherwise unused remote conversation.API reference: https://developers.openai.com/api/reference/python/resources/conversations/subresources/items/methods/list
Test plan
uv run pytest -q tests/memory/test_openai_conversations_session.py(37 passed)uv run ruff check src/agents/memory/openai_conversations_session.py tests/memory/test_openai_conversations_session.pyuv run mypy src/agents/memory/openai_conversations_session.pygit diff --checkThe repository-wide verification script was not run locally; this PR remains Draft while CI supplies the broader regression signal.
Issue number
N/A
Checks
.agents/skills/code-change-verification/scripts/run.sh/reviewbefore submitting this PR