Skip to content

chore: don't log non-error message at error level#3091

Open
rhafer wants to merge 1 commit into
opencloud-eu:mainfrom
rhafer:silence-search-log
Open

chore: don't log non-error message at error level#3091
rhafer wants to merge 1 commit into
opencloud-eu:mainfrom
rhafer:silence-search-log

Conversation

@rhafer

@rhafer rhafer commented Jul 8, 2026

Copy link
Copy Markdown
Member

When walking the tree for creating the search index, ignore "not found" errors. Search indexing happens asynchronously so the underlying space, file or folder might just not exist anymore when the indexing starts.

@rhafer
rhafer requested review from dragonchaser and fschade July 8, 2026 10:13
@rhafer rhafer self-assigned this Jul 8, 2026
@rhafer rhafer added the Type:Maintenance E.g. technical debt, packaging, etc. label Jul 8, 2026
@codacy-production

codacy-production Bot commented Jul 8, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 duplication

Metric Results
Duplication 0

View in Codacy

🟢 Coverage 0.00% diff coverage

Metric Results
Coverage variation Report missing for 48e40a31
Diff coverage 0.00% diff coverage

View coverage diff in Codacy

Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (48e40a3) Report Missing Report Missing Report Missing
Head commit (1ffea70) 82477 19111 23.17%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3091) 6 0 0.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

1 Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@fschade fschade left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can’t we use errors is?

@rhafer

rhafer commented Jul 13, 2026

Copy link
Copy Markdown
Member Author

can’t we use errors is?

@fschade Not without changes to the errtypes package in reva I think.

What is your concern? Are you thinking about wrapper errors here? Then I guess we could leverage errors.As.

@fschade

fschade commented Jul 13, 2026

Copy link
Copy Markdown
Member

can’t we use errors is?

@fschade Not without changes to the errtypes package in reva I think.

What is your concern? Are you thinking about wrapper errors here? Then I guess we could leverage errors.As.

Yes, exactly, I just didn't want us to overlook it.

When walking the tree for creating the search index, ignore "not found"
errors. Search indexing happens asynchronously so the underlying space,
file or folder might just not exist anymore when the indexing starts.
@rhafer
rhafer force-pushed the silence-search-log branch from 53ed23d to 1ffea70 Compare July 14, 2026 15:05
@rhafer

rhafer commented Jul 14, 2026

Copy link
Copy Markdown
Member Author

@fschade PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type:Maintenance E.g. technical debt, packaging, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants