Skip to content

WIP: resourceread: enable strict decoding for release payload manifests #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
machine424 wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −2
Open

WIP: resourceread: enable strict decoding for release payload manifests #1444

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/resourceread/resourceread.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import (

var (
scheme = runtime.NewScheme()
codecs = serializer.NewCodecFactory(scheme)
codecs = serializer.NewCodecFactory(scheme, serializer.EnableStrict)

@coderabbitai coderabbitai Bot Aug 12, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📐 Maintainability & Code Quality | 🟠 Major | ⚡ Quick win

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
set -euo pipefail

rg -n 'codecs = serializer.NewCodecFactory\(scheme, serializer.EnableStrict\)' \
  hack/generate-lib-resources.py \
  lib/resourceread/resourceread.go

Repository: openshift/cluster-version-operator

Length of output: 172

🏁 Script executed:

set -euo pipefail

printf '%s\n' '--- tracked candidates ---'
git ls-files 'lib/resourceread/resourceread.go' 'hack/generate-lib-resources.py'

printf '%s\n' '--- generated file context ---'
nl -ba lib/resourceread/resourceread.go | sed -n '1,45p'

printf '%s\n' '--- generator references ---'
rg -n -C 4 'CodecFactory|EnableStrict|resourceread|generate' hack/generate-lib-resources.py

Repository: openshift/cluster-version-operator

Length of output: 334

🏁 Script executed:

set -euo pipefail

printf '%s\n' '--- generated file context ---'
cat -n lib/resourceread/resourceread.go | sed -n '1,45p'

printf '%s\n' '--- generator references ---'
rg -n -C 4 'CodecFactory|EnableStrict|resourceread|generate' hack/generate-lib-resources.py

Repository: openshift/cluster-version-operator

Length of output: 5422

Update the generator before regenerating the generated file.

hack/generate-lib-resources.py emits serializer.NewCodecFactory(scheme) while lib/resourceread/resourceread.go uses serializer.EnableStrict. Add the option to the generator, then regenerate the file.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@lib/resourceread/resourceread.go` at line 24, Update
hack/generate-lib-resources.py so its generated NewCodecFactory call includes
serializer.EnableStrict, then regenerate lib/resourceread/resourceread.go to
reflect the generator output.

Source: Coding guidelines

decoder runtime.Decoder
)

Expand Down
2 changes: 1 addition & 1 deletion pkg/cvo/internal/operatorstatus.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ import (

var (
osScheme = runtime.NewScheme()
osCodecs = serializer.NewCodecFactory(osScheme)
osCodecs = serializer.NewCodecFactory(osScheme, serializer.EnableStrict)

osMapper = resourcebuilder.NewResourceMapper()
)
Expand Down