[release-5.0] OU-1107 OU-1108: ACM alerting UI with alerts and perses - #1143
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: OU-1107, OU-1108 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/lgtm |
|
Scheduling required tests: |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: openshift-cherrypick-robot, PeterYurkovich The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@openshift-cherrypick-robot: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| import { commonPages } from '../../views/common'; | ||
| import { nav } from '../../views/nav'; | ||
| import { acmAlertingPage } from '../../views/acm-alerting-page'; | ||
| import { troubleshootingPanelPage } from 'cypress/views/troubleshooting-panel'; |
There was a problem hiding this comment.
all the other imports are relative, can we use the same or maybe apply an alias? for example @/e2e as we might migrate to playwright
There was a problem hiding this comment.
I think we can add this change to the release-5.0 branch after this automated cherry pick merges. I will update my stack to fix it on the main branch
5 participants
This is an automated cherry-pick of #1105
/assign etmurasaki