Skip to content

OSDOCS: Note that changing cgroupMode reboots nodes - #117208

Open
gauravsoniiii wants to merge 1 commit into
openshift:enterprise-4.18from
gauravsoniiii:osdocs-cgroup-mode-reboot-note
Open

OSDOCS: Note that changing cgroupMode reboots nodes#117208
gauravsoniiii wants to merge 1 commit into
openshift:enterprise-4.18from
gauravsoniiii:osdocs-cgroup-mode-reboot-note

Conversation

@gauravsoniiii

Copy link
Copy Markdown

Changing nodes.config spec.cgroupMode updates MachineConfig kernel arguments; the MCO drains and reboots nodes. The procedure only described SchedulingDisabled → Ready, which omitted the reboot.

Jira:

Description:

  • Document that changing spec.cgroupMode on nodes.config/cluster causes the Machine Config Operator (MCO) to drain and reboot nodes.
  • Previously, the "Configuring Linux cgroup" procedure only showed nodes entering Ready,SchedulingDisabled and returning to Ready, which can be read as a non-disruptive config apply. In practice, this change updates MachineConfig kernelArguments, so nodes must reboot for the new cgroup configuration to take effect.

Version(s):

  • 4.14, 4.15, 4.16, 4.17, 4.18

Issue:

  • The procedure "Configuring Linux cgroup" (nodes-clusters-cgroups-2) does not state that changing spec.cgroupMode on nodes.config/cluster causes the Machine Config Operator to drain and reboot nodes.

  • Changing cgroupMode renders new MachineConfigs with updated kernelArguments (systemd.unified_cgroup_hierarchy, cgroup_no_v1, etc.). Kernel-argument changes only take effect after a full node reboot (standard MCO cordon → drain → reboot → uncordon behavior). The published Verification steps only mention Ready,SchedulingDisabled and return to Ready, which customers read as a non-disruptive config apply.

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Changing nodes.config spec.cgroupMode updates MachineConfig
kernel arguments; the MCO drains and reboots nodes. The procedure
only described SchedulingDisabled → Ready, which omitted the reboot.
@openshift-ci openshift-ci Bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2026
@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

Hi @gauravsoniiii. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@gauravsoniiii: The label(s) `/label peer-review-needed

cannot be applied. These labels are supported:acknowledge-critical-fixes-only, platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, ux-approved, no-qe, rebase/manual, cluster-config-api-changed, run-integration-tests, verified, ready-for-human-review, approved, backport-risk-assessed, bugzilla/valid-bug, cherry-pick-approved, cloud-experts, cnv, dev-tools, distributed-tracing, ims, jira/skip-dependent-bug-check, jira/valid-bug, merge-review-in-progress, merge-review-needed, mtc, multi-arch, oadp, ok-to-test, rhacs, rhv, sd-docs, serverless, service-mesh, sme-review-done, sme-review-needed, stability-fix-approved, staff-eng-approved, telco. Is this label configured under labels -> additional_labelsorlabels -> restricted_labelsinplugin.yaml`?

Details

In response to this:

/label peer-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gauravsoniiii

Copy link
Copy Markdown
Author

/label merge-review-needed

@openshift-ci

openshift-ci Bot commented Aug 4, 2026

Copy link
Copy Markdown

@gauravsoniiii: The label(s) merge-review-needed cannot be applied or removed, because you are not in one of the allowed teams and are not an allowed user. Must be a member of one of these teams: team-red-hat

Details

In response to this:

/label merge-review-needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant