Make conditional release in the set details page use a select.#3080
Make conditional release in the set details page use a select.#3080Alex-Jordan wants to merge 1 commit into
Conversation
|
Also I should note that the time taken to fire up Claude, ask it to work, review its work, and test it out a few ways was about 20 minutes. Of course, this is not a super complicated feature. BTW, while testing, I notice that when we export a set definition file, it does not carry the conditional release data. Should it? I rarely transfer set definition files anymore. I can't decide if it would be good for them to carry conditional release data or if that should be left for the new instructor to carry out. |
drgrice1
left a comment
There was a problem hiding this comment.
This generally looks good. I just have some minor quibbles on the code formatting.
Co-authored-by: Claude <noreply@anthropic.com>
9b2452f to
4ade6b4
Compare
|
I made those changes. I noted that there were places where Claude's conditional logic code was not the way I would have done it, and these ternary expressions were those places. For a first run, I thought I'd leave things exactly as Claude made them. Just to see. But if I continue using Claude I'll be making more changes. I already needed that with #3081. |
This is the first thing I've tried using Claude for. It addresses #794.
For this, I let Claude do it's thing. I monitored the process, and approved each request it made to alter code or run a test. I did not change anything that Claude did. I reviewed the code, and it seems fine to me. Although in places, conditional logic is maybe not the way I would have done it.
The feature works. Now instead of typing a comma-separated list of set IDs, you just select from a multiselect.
A few things are impressive, but one that stands out to me is that Claude knew to exclude the current set from the list of sets to conditionally release upon. Unless I'm missing something, I don't see that there was previously a check for that. And I did not prompt it to do this.