Skip to content

Hide leading shell chrome in GitHub detail tabs - #710

Merged
sudomaggie merged 1 commit into
developfrom
dev/github-detail-hide-leading-chrome
Aug 6, 2026
Merged

Hide leading shell chrome in GitHub detail tabs#710
sudomaggie merged 1 commit into
developfrom
dev/github-detail-hide-leading-chrome

Conversation

@Harry19081

Copy link
Copy Markdown
Member

Problem

GitHub issue and pull-request detail tabs disable the sidebar toggle, but the surrounding shell still reserves and renders its leading chrome. That leaves an unnecessary control area in detail-only tabs.

Solution

Mark both GitHub detail renderers with shellLeadingChromeHidden so the shell removes the entire leading chrome region while preserving the rest of each tab header configuration.

Potential risks

The change is limited to GitHub issue and pull-request detail tabs. A shell implementation that does not honor shellLeadingChromeHidden would retain the old appearance, but no data or navigation behavior changes. Manual desktop visual evidence is still pending, so this PR remains a draft.

Verification

  • pnpm exec eslint src/modules/WorkStation/TabContent/renderers/githubIssueDetail.tsx src/modules/WorkStation/TabContent/renderers/githubPrDetail.tsx — passed.
  • pnpm typecheck — passed.
  • Manual desktop verification was not run because local UI control was not authorized for this task.

Pre-commit hook ran. Total eslint: 3, total circular: 0
@Harry19081
Harry19081 marked this pull request as ready for review August 6, 2026 12:59
@sudomaggie
sudomaggie merged commit 2148ca2 into develop Aug 6, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants