Skip to content

OSAC-3534: Set archived=true for repos merged into osac mono-repo - #158

Merged
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
omer-vishlitzky:feat/OSAC-3534-archive-merged-repos
Aug 2, 2026
Merged

OSAC-3534: Set archived=true for repos merged into osac mono-repo#158
omer-vishlitzky merged 1 commit into
osac-project:mainfrom
omer-vishlitzky:feat/OSAC-3534-archive-merged-repos

Conversation

@omer-vishlitzky

@omer-vishlitzky omer-vishlitzky commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set archived = true on 6 repos merged into the osac mono-repo: fulfillment-service, osac-operator, osac-aap, osac-installer, bare-metal-fulfillment-operator, osac-csi-driver
  • These repos were already archived on GitHub but Terraform still had only lock_branch = true, creating drift
  • Updated comments to reflect archived state (replacing "pending archival" language)

Context

Test plan

  • tofu plan shows only the expected archived attribute changes (no other drift)
  • After apply, repos remain archived with correct settings

Assisted-by: Claude Code noreply@anthropic.com

Summary by CodeRabbit

  • Chores
    • Updated merged component repositories to display archived status.
    • Retained branch locking for archived repositories to prevent unintended changes.
    • Simplified repository status information by removing outdated archival and freeze notes.

The six component repos (fulfillment-service, osac-operator, osac-aap,
osac-installer, bare-metal-fulfillment-operator, osac-csi-driver) have
been merged into the osac mono-repo and archived on GitHub. Align
Terraform state to prevent drift on the next auto-apply cycle.

Assisted-by: Claude Code <noreply@anthropic.com>
Signed-off-by: omer-vishlitzky <omer.vishlitzky@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: osac-project/coderabbit/.coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: dedaf645-9af2-4071-9790-04beaac6d721

📥 Commits

Reviewing files that changed from the base of the PR and between 292db6f and 30ace54.

📒 Files selected for processing (1)
  • repositories.tf

Walkthrough

The Terraform repository declarations mark six merged component repositories as archived. Existing branch locks remain. Obsolete pending-archival and freeze comments are removed or shortened.

Changes

Repository archival

Layer / File(s) Summary
Archived repository declarations
repositories.tf
The declarations for fulfillment-service, osac-operator, osac-aap, osac-installer, bare-metal-fulfillment-operator, and osac-csi-driver now set archived = true. Existing branch locking remains. Obsolete archival and freeze comments are removed or replaced with concise comments.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: larsks, eliorerz

🚥 Pre-merge checks | ✅ 11
✅ Passed checks (11 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the change and matches the six repositories being marked as archived in Terraform.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
No-Hardcoded-Secrets ✅ Passed The PR adds only archived/lock settings and archival comments; scans found no API keys, tokens, passwords, private keys, credential URLs, or long encoded blobs.
No-Weak-Crypto ✅ Passed The PR changes only Terraform repository flags and comments; the patch adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
No-Injection-Vectors ✅ Passed The HEAD diff changes only repositories.tf comments and literal Terraform archived/lock_branch settings; repository-wide searches found no listed injection patterns.
Container-Privileges ✅ Passed The PR changes only Terraform repository settings. No container or Kubernetes manifests, privileged fields, host namespaces, SYS_ADMIN, or allowPrivilegeEscalation settings are present.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only Terraform repository flags and comments; it adds no logging or sensitive values such as passwords, tokens, PII, hostnames, or customer data.
Ai-Attribution ✅ Passed The PR and commit disclose Claude Code with an Assisted-by trailer; the commit has no AI Co-Authored-By trailer.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@eranco74 eranco74 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@omer-vishlitzky
omer-vishlitzky merged commit 0ea3007 into osac-project:main Aug 2, 2026
2 checks passed
eliorerz added a commit that referenced this pull request Aug 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants