Resolve seccomp profile on bin/up and bin/upgrade - #441
Open
mserranom wants to merge 1 commit into
Open
Conversation
Contributor
Author
mserranom
commented
Aug 26, 2026
| if [[ $SERVER_PRO == "true" && "$SIBLING_CONTAINERS_ENABLED" == "true" ]]; then | ||
| pull_sandboxed_compiles | ||
| set_server_pro_image_name "$IMAGE_VERSION" | ||
| ensure_seccomp_profile || true |
Contributor
Author
There was a problem hiding this comment.
Not sure about this, should we print the warnings and let the user continue with the setup, or halt here?
Cc @mlevans0
Collaborator
There was a problem hiding this comment.
My thinking was that for any of the hardening types of changes we’d just let the container start even though it wouldn’t work as it would help with debugging for their modules/policies. A non working container allows the customer to click around and trigger events to fix.
Contributor
Author
There was a problem hiding this comment.
Cool, let's keep it as it is then, and revisit once we have further feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds resolution of seccomp profile in
bin/upandbin/upgradescripts.extract_seccomp_profile_from_imagetoshared_functions, which is used inbin/podman_setup.ensure_seccomp_profiletoshared_functions. Performs the relevant checks (SP + Sibling Containers + podman) before extracting the profile.ensure_seccomp_profiletobin/upandbin/upgradescripts.bin/doctor: the seccomp check block is now gated onSERVER_PRO=true && SIBLING_CONTAINERS_ENABLED=true, matching the SELinux gate right above it.Related issues / Pull Requests
Contributor Agreement