Compass: Design guidelines and demo updates - #5051
Merged
Merged
Conversation
dlabaj
requested changes
Jul 8, 2026
dlabaj
left a comment
dlabaj
left a comment
Contributor
There was a problem hiding this comment.
Undo the changes to webpack.base.config.js. They are not needed and are causing the build of the documentatoin site to fail.
Removed symlink path for workspace builds and disabled symlinks in the Webpack configuration.
Collaborator
phcox
reviewed
Jul 8, 2026
phcox
reviewed
Jul 8, 2026
|
|
||
| The main content region fills the center of the viewport. It typically contains: | ||
|
|
||
| - **Main header:** A title area or hero section that contextualizes the current view. |
Contributor
There was a problem hiding this comment.
I suggest using the same names in this list as the ones that are used in the image above. That said, using "Main header" or "Header content" runs a risk of creating confusion with the distinct Header section. "Hero area" or "Hero section" might work.
phcox
reviewed
Jul 8, 2026
| - The glass theme is typically applied globally to the `html` element, similar to enabling dark mode. | ||
| - Glass mode works best with a full-page background image. | ||
| - Wrap glass-styled containers in a `Panel` with the `isGlass` modifier. | ||
| - Do not nest glass-styled `Panel` stacks, as this can cause unintended visual artifacts. |
Contributor
There was a problem hiding this comment.
Would "unintended visual artifacts" mean legibility and accessibility issues? If so, I would go ahead and just say that, or just add ", such as legibility and accessibility issues."
nicolethoen
approved these changes
Aug 4, 2026
Collaborator
|
Your changes have been released in:
Thanks for your contribution! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5050