Skip to content

Avoid call invalidate after the View is detach. #87

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
peerless2012 merged 1 commit into from
Aug 11, 2026
Merged

Avoid call invalidate after the View is detach. #87

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions lib_ass_media/src/main/java/io/github/peerless2012/ass/media/widget/AssSubtitleCanvasView.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,9 @@ class AssSubtitleCanvasView : View, AssSubtitleRender {
private var renderSize = Size.ZERO

// Use a local param, avoid create each time.
private val invalidateCallback = Runnable { invalidate() }
private val invalidateCallback = Runnable {
if (isAttachedToWindow) invalidate()
}

// Use a local param, avoid create each time.
private val assRenderCallback: (AssFrame?) -> Unit = assRenderCallback@{ assFrame ->
Expand All @@ -49,7 +51,7 @@ class AssSubtitleCanvasView : View, AssSubtitleRender {
it.bitmap?.prepareToDraw()
}
this.assFrame = assFrame
handler.post(invalidateCallback)
post(invalidateCallback)
}

constructor(context: Context, assHandler: AssHandler) : this(context, null, assHandler)
Expand Down Expand Up @@ -127,6 +129,8 @@ class AssSubtitleCanvasView : View, AssSubtitleRender {
assHandler.renderCallback = null
assExecutor?.shutdown()
assExecutor = null
removeCallbacks(invalidateCallback)
assFrame = null
super.onDetachedFromWindow()
}
}