fix(datagrid): restore persisted column widths - #3214
Open
LarryHu0217 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Liang Hu <lh3057@columbia.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the first Datagrid restore, saved column widths could be discarded in two places: the viewer schema filtered out the plugin-owned
columnskey, and the width restore could run before the plugin andregular-tablehad finished their initial draw.This change:
columnsas passthrough plugin config so it survives schema filteringregular-tabledraw completesFixes #3163.
Validation
PACKAGE=viewer-datagrid pnpm run lintpnpm --filter @perspective-dev/metadata run buildpnpm --filter @perspective-dev/server run buildpnpm --filter @perspective-dev/client run buildpnpm --filter @perspective-dev/viewer run buildpnpm --filter @perspective-dev/viewer-datagrid run buildPACKAGE=viewer-datagrid pnpm exec playwright test --config=tools/test/playwright.config.ts packages/viewer-datagrid/test/js/column_settings.spec.ts --grep=First(1 passed)git diff --checkDocumentation is not applicable because this fixes existing persistence behavior and does not add a public API.
AI assistance
I used OpenAI Codex to inspect the codebase, assist with the implementation and regression test, and run and review the validation steps. I reviewed the final diff and test results myself.