docs: log Codacy backlog real numbers to tech-debt - #34
Merged
Conversation
Raised 2026-07-29 when comparing Codacy's 443-issue dashboard against the mixin-hygiene work happening the same day -- only the bare-except finding genuinely overlapped (since fixed). Logging the real numbers now instead of re-deriving them from scratch later. Reproduced with `ruff check --select F` against clean origin/main: 883 hits, categorized (F405 469, F401 240, F841 49, F403 47, F811 43, F821 29, F541 6). Confirmed Codacy's Python engine is Prospector (Pylint+Pyflakes+Bandit+pycodestyle+pydocstyle+mccabe) via the dashboard's own docs tab and Pylint/Bandit-style pattern names. Called out the 29 F821 (undefined name) hits specifically -- a real-bug class, not style, since an undefined name raises NameError if that code path ever actually executes -- with full locations (BundleAdjust.py, ImageSpatial.py, VisualServo.py, blocks/camera.py, tests/test_camera.py) so a future session can triage directly instead of re-running the sweep.
Concrete instances found while those PRs were in review: type shadows the builtin at both Histogram.plot's signature (#32) and _compute_plot_series (#33, copied from plot's signature during extraction). Deliberately not renamed in either PR -- public API, needs a real deprecation cycle. Documented the fix path (mirror the existing bar=/filled= deprecated-alias pattern already used in this same method) and the sequencing constraint (do it after #32/#33 merge, not before, to avoid a guaranteed conflict on the same lines). Also logged 3 more Codacy findings from PR #33's __getitem__ extraction, all pre-existing/already-covered: max as a parameter name (carried over verbatim from the original nested closure) and two more F405 star-import-ambiguity hits already covered by the existing F405 entry above.
Up to standards ✅🟢 Issues
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ruff check --select Fagainst cleanorigin/main: 883 hits, categorized by code. Calls out the 29F821(undefined name) hits specifically with full locations — a real-bug class, not style, worth triaging first.type=builtin-shadowing onHistogram.plot, plus a few pre-existing/already-covered findings from the__getitem__extraction) with a documented fix path fortype=(mirror the existingbar=/filled=deprecated-alias pattern) and an explicit note to do that after fix: add missing type annotations, warn on ncdf deprecation #32/refactor: extract-method hygiene pass on 3 large methods (finding 8) #33 merge to avoid a guaranteed conflict.No code changes — tech-debt.md only.