fix: add socket timeout to iread() URL fetches - #37
Merged
Conversation
urlopen() had no timeout, so a stalled SSL handshake against a slow or unresponsive server hung indefinitely -- in production this means iread() on a URL can hang forever; in CI it meant pytest's own blunt --timeout=50 thread-kill fired first, surfacing as a hard test failure instead of the graceful except URLError: SkipTest the test was already written to hit. A stalled connection now raises URLError (wrapping TimeoutError) well inside any reasonable timeout window, which both iread()'s existing except clause and the test's SkipTest path already handle correctly.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iread()'s URL-fetch path calledurllib.request.urlopen(req, context=ctx)with notimeout=-- a stalled SSL handshake against a slow/unresponsive server hung indefinitely. This was hit repeatedly this session as CI flakiness:tests/base/test_io.py'stest_iread/test_iread_url_handlingfetch a real image frompetercorke.com, and an occasional stalled handshake let pytest's own blunt--timeout=50thread-kill fire first, surfacing as a hard failure instead of the gracefulexcept URLError: SkipTestthe tests were already written to hit.iread()on a slow URL hangs forever the same way.timeout=10to theurlopen()call. Verified empirically that a stalled connection raisesURLErrorwrappingTimeoutError(not some other exception type), which bothiread()'s existing except clause and the tests'SkipTestpath already handle correctly -- no other code changes needed.Test plan
urllib.error.URLErrorwrappingTimeoutError, confirming the existing except clause catches it.tests/base/test_io.pyin isolation: 125 passed in 3.7s (real network fetch succeeded well within the new budget).